-
Notifications
You must be signed in to change notification settings - Fork 35
test(metadata): add explicit tests for slugger regexp replacements #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shivxmsharma
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
shivxmsharma:test/slugger-regexps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
118 changes: 118 additions & 0 deletions
118
src/generators/metadata/utils/__tests__/slugger.test.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| 'use strict'; | ||
|
|
||
| import assert from 'node:assert/strict'; | ||
| import { describe, it } from 'node:test'; | ||
|
|
||
| import createNodeSlugger, { slug } from '../slugger.mjs'; | ||
|
|
||
| const identity = str => str; | ||
|
|
||
| describe('slug', () => { | ||
| describe('node.js replacement', () => { | ||
| it('replaces "node.js" with "nodejs"', () => { | ||
| assert.strictEqual(slug('node.js', identity), 'nodejs'); | ||
| }); | ||
|
|
||
| it('is case-insensitive', () => { | ||
| assert.strictEqual(slug('Node.JS', identity), 'nodejs'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('ampersand replacement', () => { | ||
| it('replaces & with -and-', () => { | ||
| assert.strictEqual(slug('a&b', identity), 'a-and-b'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('special character to hyphen replacement', () => { | ||
| it('replaces underscores with hyphens', () => { | ||
| assert.strictEqual(slug('foo_bar', identity), 'foo-bar'); | ||
| }); | ||
|
|
||
| it('replaces forward slashes with hyphens', () => { | ||
| assert.strictEqual(slug('foo/bar', identity), 'foo-bar'); | ||
| }); | ||
|
|
||
| it('replaces colons with hyphens', () => { | ||
| assert.strictEqual(slug('foo:bar', identity), 'foo-bar'); | ||
| }); | ||
|
|
||
| it('replaces commas with hyphens', () => { | ||
| assert.strictEqual(slug('foo,bar', identity), 'foo-bar'); | ||
| }); | ||
|
|
||
| it('replaces semicolons with hyphens', () => { | ||
| assert.strictEqual(slug('foo;bar', identity), 'foo-bar'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('leading hyphen removal', () => { | ||
| it('removes a single leading hyphen', () => { | ||
| assert.strictEqual(slug('-foo', identity), 'foo'); | ||
| }); | ||
|
|
||
| it('removes multiple leading hyphens', () => { | ||
| assert.strictEqual(slug('--foo', identity), 'foo'); | ||
| }); | ||
|
|
||
| it('preserves an all-hyphen string', () => { | ||
| assert.strictEqual(slug('---', identity), '---'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('trailing hyphen removal', () => { | ||
| it('removes a single trailing hyphen', () => { | ||
| assert.strictEqual(slug('foo-', identity), 'foo'); | ||
| }); | ||
|
|
||
| it('removes multiple trailing hyphens', () => { | ||
| assert.strictEqual(slug('foo--', identity), 'foo'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('consecutive hyphen replacement', () => { | ||
| it('replaces from start of string up to and including double-hyphen with a single hyphen', () => { | ||
| assert.strictEqual(slug('foo--bar', identity), '-bar'); | ||
| }); | ||
|
|
||
| it('does not fire on an all-hyphen string', () => { | ||
| assert.strictEqual(slug('---', identity), '---'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('integration with github-slugger', () => { | ||
| it('lowercases and hyphenates a plain title', () => { | ||
| assert.strictEqual(slug('Hello World'), 'hello-world'); | ||
| }); | ||
|
|
||
| it('converts underscored names to hyphenated slugs', () => { | ||
| assert.strictEqual(slug('child_process'), 'child-process'); | ||
| }); | ||
|
|
||
| it('handles titles with no special characters', () => { | ||
| assert.strictEqual(slug('stability index'), 'stability-index'); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('createNodeSlugger', () => { | ||
| it('deduplicates the same slug by appending a counter', () => { | ||
| const slugger = createNodeSlugger(); | ||
| assert.strictEqual(slugger.slug('Hello'), 'hello'); | ||
| assert.strictEqual(slugger.slug('Hello'), 'hello-1'); | ||
| assert.strictEqual(slugger.slug('Hello'), 'hello-2'); | ||
| }); | ||
|
|
||
| it('does not affect different titles', () => { | ||
| const slugger = createNodeSlugger(); | ||
| assert.strictEqual(slugger.slug('First'), 'first'); | ||
| assert.strictEqual(slugger.slug('Second'), 'second'); | ||
| }); | ||
|
|
||
| it('each instance has independent state', () => { | ||
| const slugger1 = createNodeSlugger(); | ||
| const slugger2 = createNodeSlugger(); | ||
| slugger1.slug('Hello'); | ||
| assert.strictEqual(slugger2.slug('Hello'), 'hello'); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.