Merge pull request libgit2#3818 from meatcoder/fix_odb_read_error

Edward Thomson · Edward Thomson · commit c80efb5f6db4 · 2016-06-20T11:16:49.000-04:00
Fix truncation of SHA in error message for git_odb_read
diff --git a/src/odb.c b/src/odb.c
@@ -1362,7 +1362,7 @@ int git_odb__error_notfound(
 {
 	if (oid != NULL) {
 		char oid_str[GIT_OID_HEXSZ + 1];
-		git_oid_tostr(oid_str, oid_len, oid);
+		git_oid_tostr(oid_str, oid_len+1, oid);
 		giterr_set(GITERR_ODB, "Object not found - %s (%.*s)",
 			message, oid_len, oid_str);
 	} else

Original file line number	Diff line number	Diff line change
`@@ -1362,7 +1362,7 @@ int git_odb__error_notfound(`
`1362`	`1362`	`{`
`1363`	`1363`	`if (oid != NULL) {`
`1364`	`1364`	`char oid_str[GIT_OID_HEXSZ + 1];`
`1365`		`- git_oid_tostr(oid_str, oid_len, oid);`
	`1365`	`+ git_oid_tostr(oid_str, oid_len+1, oid);`
`1366`	`1366`	`giterr_set(GITERR_ODB, "Object not found - %s (%.*s)",`
`1367`	`1367`	`message, oid_len, oid_str);`
`1368`	`1368`	`} else`