Merge pull request libgit2#3827 from dbrnz/basic_auth

Edward Thomson · web-flow · commit 24d10cac1217 · 2016-06-20T11:09:31.000-04:00
HTTP authentication scheme name is case insensitive.
diff --git a/src/transports/http.c b/src/transports/http.c
@@ -114,7 +114,7 @@ static bool challenge_match(git_http_auth_scheme *scheme, void *data)
 	size_t scheme_len;
 
 	scheme_len = strlen(scheme_name);
-	return (strncmp(challenge, scheme_name, scheme_len) == 0 &&
+	return (strncasecmp(challenge, scheme_name, scheme_len) == 0 &&
 		(challenge[scheme_len] == '\0' || challenge[scheme_len] == ' '));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ static bool challenge_match(git_http_auth_scheme scheme, void data)`
`114`	`114`	`size_t scheme_len;`
`115`	`115`
`116`	`116`	`scheme_len = strlen(scheme_name);`
`117`		`- return (strncmp(challenge, scheme_name, scheme_len) == 0 &&`
	`117`	`+ return (strncasecmp(challenge, scheme_name, scheme_len) == 0 &&`
`118`	`118`	`(challenge[scheme_len] == '\0' \|\| challenge[scheme_len] == ' '));`
`119`	`119`	`}`
`120`	`120`