Ignore MIME parameters when choosing the parser#1044
Open
nicolo-ribaudo wants to merge 2 commits intonode-formidable:masterfrom
Open
Ignore MIME parameters when choosing the parser#1044nicolo-ribaudo wants to merge 2 commits intonode-formidable:masterfrom
nicolo-ribaudo wants to merge 2 commits intonode-formidable:masterfrom
Conversation
nicolo-ribaudo
commented
Sep 1, 2025
| } catch (e) { | ||
| server.close(); | ||
| done(e); | ||
| throw e; |
Author
There was a problem hiding this comment.
This new try-catch is because otherwise the test was just timing out rather than reporting the error.
tunnckoCore
approved these changes
Sep 22, 2025
Author
|
Ping? :) It's not affecting me directly since I just disabled the JSON parser for my use case, but it was a quite annoying problem to debug so merging it could benefit other users. |
Member
|
@nicolo-ribaudo yeah, for sure. But not much happened recently, i have it in mind. Tho, i was trying v4 in couple of places which doesn't have any of this category of problems. For now, the plan is to move |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mime types are in the form
foo/bar;param=value. When checking what type of request we have, we should only check thefoo/barpart and not theparam=valuepart.Fixes #1043