Network refactor pt1#2109
Merged
ItsLemmy merged 15 commits intonoctalia-dev:mainfrom Mar 14, 2026
Merged
Conversation
Contributor
Author
|
Conflict fixed. |
14 tasks
…tor-pt1 # Conflicts: # Modules/Panels/Network/WiFiNetworksList.qml
ItsLemmy
reviewed
Mar 13, 2026
ItsLemmy
reviewed
Mar 13, 2026
ItsLemmy
reviewed
Mar 13, 2026
ItsLemmy
reviewed
Mar 13, 2026
ItsLemmy
reviewed
Mar 13, 2026
ItsLemmy
reviewed
Mar 13, 2026
ItsLemmy
reviewed
Mar 13, 2026
| radius: Style.radiusM | ||
| clip: true | ||
|
|
||
| color: (modelData.connected && NetworkService.disconnectingFrom !== modelData.ssid) ? Qt.alpha(Color.mPrimary, Math.min(1.15 - Settings.data.ui.panelBackgroundOpacity, 0.75)) : Color.mSurface |
Collaborator
There was a problem hiding this comment.
Color.panelBackgroundOpacity
ItsLemmy
reviewed
Mar 13, 2026
Collaborator
|
With that implementation it seems there is no way to re-trigger a scan, the only way is too close and re-open the panel, is that intentional? what is the rational behind this? |
Contributor
Author
|
I think i addressed all of it. |
Collaborator
|
Thanks a lot! |
Contributor
Author
|
fyi: pt1 is not perfect nor pt2 - but pt2 including lot of QoL improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type of Change
Mark the relevant option with an "x".
Related Issue
#800
Testing
Describe how you tested your changes and mark the relevant items.
Screenshots / Videos
Checklist
Additional Notes
N/A