UpdateingImage: allow empty command line#6
Open
jinliu wants to merge 1 commit into
Open
Conversation
It will assume that the image is updated by some external process, and only periodically reload it.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a fast-path for when commandLine is not configured, ensuring the widget displays a static image without invoking async execution.
Changes:
- Early-return in
update()whencommandLineis nil/empty - Set the widget image once in the no-command case
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+80
to
+86
| if not commandLine or commandLine == "" then | ||
| if not imageSet then | ||
| barWidget.setImage(imagePath, true, imageWidth, imageHeight) | ||
| imageSet = true | ||
| end | ||
| return | ||
| end |
| local imageSet = false | ||
|
|
||
| function update() | ||
| if not commandLine or commandLine == "" then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It will assume that the image is updated by some external process, and only auto-reload it.