Add comprehensive test coverage for MetricGroup.Output and executeCheck#33
Merged
Add comprehensive test coverage for MetricGroup.Output and executeCheck#33
Conversation
Owner
nmollerup
commented
Dec 8, 2025
nmollerup
commented
- Add TestMetricGroupOutput with test cases for various tag configurations and metric scenarios (no tags, single tag, multiple tags, multiple metrics, and dots in metric names)
- Add TestExecuteCheck with test cases covering normal operation, metrics mode, human-readable mode, extra tags, low thresholds, and pseudo filesystem inclusion
- Remove debug print statement from checkArgs function in main.go
- Achieves 100% function test coverage (all functions now tested)
- Add TestMetricGroupOutput with test cases for various tag configurations and metric scenarios (no tags, single tag, multiple tags, multiple metrics, and dots in metric names) - Add TestExecuteCheck with test cases covering normal operation, metrics mode, human-readable mode, extra tags, low thresholds, and pseudo filesystem inclusion - Remove debug print statement from checkArgs function in main.go - Achieves 100% function test coverage (all functions now tested)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.