Open
Conversation
Currently cygwin build is supported, while cygwin is actually mingw, it
has its own flags and settings to build native windows executables.
This change adds minimal support for mingw build keeping backward
compatibility.
Changes:
* Case sensitive paths, the SDK uses Include and Lib directories, while
build had include and lib.
* Move -mno-cygwin flag to CYGWIN_FLAGS so that it can be overridden,
default remains the same.
* Add LIBARCH make variable to be able to link against a specific
variant of library.
* Add missing winsock linkage when needed and convert existing to
winsock2.
Build using mingw-w64 is supported using:
make CC=x86_64-w64-mingw32-gcc CYGWIN_FLAGS= LIBARCH=/x64
Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Author
|
BTW: I suggest to drop cygwin by adding |
|
Dear https://github.com/nmap team, Have you seen this PR? |
Author
|
@bonsaiviking: may you interested in review? Thanks! |
|
BUMP! Why has this not been merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently cygwin build is supported, while cygwin is actually mingw, it has its own flags and settings to build native windows executables.
This change adds minimal support for mingw build keeping backward compatibility.
Changes:
Build using mingw-w64 is supported using:
Signed-off-by: Alon Bar-Lev alon.barlev@gmail.com