-
Notifications
You must be signed in to change notification settings - Fork 0
Split instructions.txt into logical sections for better navigation #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Split .cursor/rules/instructions.txt into 7 logical .mdc files - Created .cursor/rules/claude.md index linking to all sections - Created root-level claude.md linking to rules and index - Preserved original instructions.txt file - Added numbered sections: llm-info, corey-info, corey-behavior, nodejs-style-guide, typescript-style-guide, encore-ts-domain-knowledge, encore-cli-reference
- Add CI workflow for pull requests to main branch - Includes PostgreSQL service for database testing - Runs backend tests with Encore CLI - Runs frontend tests with Bun - Builds both backend and frontend - Uses latest Bun version and Encore CLI
7db2df8 to
82d3190
Compare
…each .mdc rule file\n- Add helper script to ensure we only keep the first block\n- Run script to dedupe encore domain knowledge and CLI docs
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
| import fs from "node:fs"; | ||
| import path from "node:path"; | ||
|
|
||
| const rulesDir = path.resolve(path.dirname(new URL(import.meta.url).pathname)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| */ | ||
| export function Environment(name: string): BaseURL { | ||
| return `https://${name}-.encr.app` | ||
| return `https://${name}-steering-wheel-documentation-65b2.encr.app` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incorrect URL Construction in Environment Function
The Environment function constructs URLs with a hardcoded app ID "steering-wheel-documentation-65b2", which creates an invalid URL pattern. The return value https://${name}-steering-wheel-documentation-65b2.encr.app results in URLs like "https://prod-steering-wheel-documentation-65b2.encr.app" instead of the likely intended format "https://steering-wheel-documentation-65b2-prod.encr.app" or similar. This appears to be a breaking change from the previous implementation that used https://${name}-.encr.app, and the placement of the app ID is incorrect, creating malformed environment URLs.
…g sync - Update CODE_REVIEW.md: mark magic strings and hardcoded config as fixed - Fix backend/graph/stream.ts: use RUN_ENDED_STATUSES constant (no magic strings) - Fix frontend config: extract defaults to frontend/src/lib/config.ts with env overrides - Add FR-010 feature request: centralized run defaults via Encore endpoint - Update debugging skills: add WebSocket/Docker infrastructure notes - Update handoff docs: document graph stream debugging findings Resolves CODE_REVIEW critical issues #1 and #2.
Summary
Split the lengthy
.cursor/rules/instructions.txtfile into logical sections for better navigation and maintainability.Changes
Split into 7 logical sections:
01-llm-info.mdc- LLM information and behavior02-corey-info.mdc- Corey assistant information03-corey-behavior.mdc- Corey behavior guidelines04-nodejs-style-guide.mdc- Node.js style guidelines05-typescript-style-guide.mdc- TypeScript style guidelines06-encore-ts-domain-knowledge.mdc- Encore.ts domain knowledge07-encore-cli-reference.mdc- Encore CLI referenceCreated navigation indexes:
.cursor/rules/claude.md- Index linking to all split sectionsclaude.md(root) - Master index linking to rules and sectionsPreserved original:
instructions.txtremains intactBenefits
Files Added
.mdcsection filesclaude.mdlocations)instructions_archived.txtNote
Splits monolithic rules into modular .mdc files with indexes, adds a full CI workflow, updates docs, and regenerates the frontend Encore client with app-specific URLs.
.cursor/rules/instructions.txtinto modular.mdcfiles (01-07), including large Encore.ts knowledge and CLI reference, plus indexes (.cursor/rules/claude.md, rootclaude.md)..cursor/rules/instructions_archived.txt..cursor/rules/dedupe_rules.jsto trim duplicated XML blocks..github/workflows/ci.ymlwith Postgres service; installs Encore CLI and Bun; runs backend tests/build (encore test/build) and frontend tests/build (bun test,bun run build).frontend/client.ts(header,Environment()base URL to app-specific subdomain, serverUser-Agent).backend/.gitignoreentries for Encore-generated artifacts.Written by Cursor Bugbot for commit 8092ebb. This will update automatically on new commits. Configure here.