Skip to content

Conversation

@nirukk52
Copy link
Owner

@nirukk52 nirukk52 commented Oct 24, 2025

Summary

Split the lengthy .cursor/rules/instructions.txt file into logical sections for better navigation and maintainability.

Changes

  • Split into 7 logical sections:

    • 01-llm-info.mdc - LLM information and behavior
    • 02-corey-info.mdc - Corey assistant information
    • 03-corey-behavior.mdc - Corey behavior guidelines
    • 04-nodejs-style-guide.mdc - Node.js style guidelines
    • 05-typescript-style-guide.mdc - TypeScript style guidelines
    • 06-encore-ts-domain-knowledge.mdc - Encore.ts domain knowledge
    • 07-encore-cli-reference.mdc - Encore CLI reference
  • Created navigation indexes:

    • .cursor/rules/claude.md - Index linking to all split sections
    • claude.md (root) - Master index linking to rules and sections
  • Preserved original:

    • Original instructions.txt remains intact
    • No data loss - all content preserved in logical sections

Benefits

  • Better navigation through modular sections
  • Easier maintenance of specific rule categories
  • Preserved original file for reference
  • Clear indexing for quick access

Files Added

  • 7 new .mdc section files
  • 2 new index files (claude.md locations)
  • Archived original as instructions_archived.txt

Note

Splits monolithic rules into modular .mdc files with indexes, adds a full CI workflow, updates docs, and regenerates the frontend Encore client with app-specific URLs.

  • Rules/Docs:
    • Split Rules: Extracts .cursor/rules/instructions.txt into modular .mdc files (01-07), including large Encore.ts knowledge and CLI reference, plus indexes (.cursor/rules/claude.md, root claude.md).
    • Archive: Adds .cursor/rules/instructions_archived.txt.
    • Utility: Adds .cursor/rules/dedupe_rules.js to trim duplicated XML blocks.
  • CI:
    • GitHub Actions: New workflow .github/workflows/ci.yml with Postgres service; installs Encore CLI and Bun; runs backend tests/build (encore test/build) and frontend tests/build (bun test, bun run build).
  • App/Client:
    • Generated Client: Updates frontend/client.ts (header, Environment() base URL to app-specific subdomain, server User-Agent).
  • Docs:
    • DEVELOPMENT.md: Refines setup/deploy instructions and dashboard links.
  • Repo:
    • Ignore: Adds backend/.gitignore entries for Encore-generated artifacts.

Written by Cursor Bugbot for commit 8092ebb. This will update automatically on new commits. Configure here.

- Split .cursor/rules/instructions.txt into 7 logical .mdc files
- Created .cursor/rules/claude.md index linking to all sections
- Created root-level claude.md linking to rules and index
- Preserved original instructions.txt file
- Added numbered sections: llm-info, corey-info, corey-behavior, nodejs-style-guide, typescript-style-guide, encore-ts-domain-knowledge, encore-cli-reference
cursor[bot]

This comment was marked as outdated.

- Add CI workflow for pull requests to main branch
- Includes PostgreSQL service for database testing
- Runs backend tests with Encore CLI
- Runs frontend tests with Bun
- Builds both backend and frontend
- Uses latest Bun version and Encore CLI
@nirukk52 nirukk52 force-pushed the feature/split-instructions-docs branch from 7db2df8 to 82d3190 Compare October 24, 2025 04:31
cursor[bot]

This comment was marked as outdated.

…each .mdc rule file\n- Add helper script to ensure we only keep the first block\n- Run script to dedupe encore domain knowledge and CLI docs
@openhands-ai
Copy link

openhands-ai bot commented Oct 24, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • CI

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #1 at branch `feature/split-instructions-docs`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

import fs from "node:fs";
import path from "node:path";

const rulesDir = path.resolve(path.dirname(new URL(import.meta.url).pathname));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Windows Path Resolution Issue in ESM

The rulesDir path resolution fails on Windows in an ESM context. new URL(import.meta.url).pathname produces invalid paths like /C:/..., preventing the script from finding files.

Fix in Cursor Fix in Web

*/
export function Environment(name: string): BaseURL {
return `https://${name}-.encr.app`
return `https://${name}-steering-wheel-documentation-65b2.encr.app`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect URL Construction in Environment Function

The Environment function constructs URLs with a hardcoded app ID "steering-wheel-documentation-65b2", which creates an invalid URL pattern. The return value https://${name}-steering-wheel-documentation-65b2.encr.app results in URLs like "https://prod-steering-wheel-documentation-65b2.encr.app" instead of the likely intended format "https://steering-wheel-documentation-65b2-prod.encr.app" or similar. This appears to be a breaking change from the previous implementation that used https://${name}-.encr.app, and the placement of the app ID is incorrect, creating malformed environment URLs.

Fix in Cursor Fix in Web

@nirukk52 nirukk52 closed this Oct 26, 2025
nirukk52 added a commit that referenced this pull request Nov 6, 2025
…g sync

- Update CODE_REVIEW.md: mark magic strings and hardcoded config as fixed
- Fix backend/graph/stream.ts: use RUN_ENDED_STATUSES constant (no magic strings)
- Fix frontend config: extract defaults to frontend/src/lib/config.ts with env overrides
- Add FR-010 feature request: centralized run defaults via Encore endpoint
- Update debugging skills: add WebSocket/Docker infrastructure notes
- Update handoff docs: document graph stream debugging findings

Resolves CODE_REVIEW critical issues #1 and #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants