Proxy process with additional exports
#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Maybe we should also cover changes from defunctzombie/node-process#80? |
niksy
commented
Nov 20, 2024
niksy
force-pushed
the
proxy-process
branch
6 times, most recently
from
c565544 to
e37fa62
Compare
susnux
reviewed
Sep 28, 2025
| const path = resolvePath('path-browserify'); | ||
| const punycode = resolvePath('punycode/'); | ||
| const _process = resolvePath('process/browser.js'); | ||
| const _process = resolvePath('./proxy/process').replace('.js', ''); |
There was a problem hiding this comment.
What is the reason for the replace? It breaks this package when used in a projected which defined "type": "module" in its package.json 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33.
This PR also includes some changes from following PRs/issues: