Skip to content

Conversation

@pstoeckle
Copy link
Contributor

@pstoeckle pstoeckle commented Oct 8, 2025

I used hadolint on the generated alpine/debian Dockerfiles, and fixed some problems.
I did NOT fix things like

  • DL3008, i.e., python3.11-nodejs20.Dockerfile:10 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
  • DL4006 python3.11-nodejs20.Dockerfile:14 DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
  • DL3013 i.e., python3.11-nodejs20.Dockerfile:34 DL3013 warning: Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>` or `pip install --requirement <requirements file>`

@nikolaik
Copy link
Owner

Thanks again @pstoeckle and I'll merge if you can help rebase first <3

@pstoeckle
Copy link
Contributor Author

Thanks again @pstoeckle and I'll merge if you can help rebase first <3

Did the rebase

@nikolaik
Copy link
Owner

Thanks again @pstoeckle and I'll merge if you can help rebase first <3

Did the rebase

wonderful!

@nikolaik nikolaik merged commit f9ba22d into nikolaik:main Oct 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants