Skip to content

Conversation

@nikolaik
Copy link
Owner

@nikolaik nikolaik commented Oct 6, 2025

Fixes #222

@nikolaik nikolaik force-pushed the nikolaik/furry-horses branch from 4e6bc5b to 1787532 Compare October 6, 2025 13:04
@nikolaik nikolaik marked this pull request as ready for review October 6, 2025 13:04
@nikolaik nikolaik requested a review from Copilot October 6, 2025 13:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds build digest functionality to versions.json by modifying the workflow to capture Docker image digests during the build process and include them in the build metadata.

  • Adds a new digest field to the BuildVersion dataclass
  • Implements load_build_contexts function to read build metadata from JSON files
  • Updates CI workflow to store build digests and pass them to the release process

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/docker_python_nodejs/versions.py Adds digest field to BuildVersion and implements load_build_contexts function
src/docker_python_nodejs/cli.py Updates release command to use build contexts from files instead of generating versions
tests/test_all.py Adds test coverage for the new load_build_contexts function
.github/workflows/build.yaml Modifies workflow to capture and store build digests in artifacts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nikolaik nikolaik force-pushed the nikolaik/furry-horses branch from 1787532 to 4554112 Compare October 6, 2025 13:09
@nikolaik nikolaik changed the title ✨ Add build digest to versions.json ✨ Add build digests to versions.json Oct 6, 2025
@nikolaik nikolaik merged commit 95db350 into main Oct 6, 2025
2 of 3 checks passed
@nikolaik nikolaik deleted the nikolaik/furry-horses branch October 6, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please allow minor versions on Node 22

2 participants