Model information (supported transport and connection string) in AddInstrumentDialog#957
Merged
azonenberg merged 1 commit intongscopeclient:masterfrom Jan 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
This PR goes with the driver model API you already merged.
It adds model information (nickname, supported transport and connection string) to AddInstrumentDialog:
For drivers that implement the GetDriverSupportedModels() method, the list of available transports will be limited to supported transports and nickname and connection string will be pre-filled.
For other drivers, the behavior of the AddInstrumentDialog remains unchanged.
If a driver lists more than one model, a model combo is added to the dialog.