Skip to content

doc: add missing information for external references #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkleinF5 merged 10 commits into from
Jan 26, 2026
Merged

doc: add missing information for external references #1545

dkleinF5 merged 10 commits into from
Jan 26, 2026
+36 −2

Conversation

@dkleinF5
Copy link
Contributor

@dkleinF5 dkleinF5 commented Dec 7, 2025 •
edited
Loading

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩

@dkleinF5 dkleinF5 requested a review from a team as a code owner December 7, 2025 14:20
@dkleinF5 dkleinF5 marked this pull request as draft December 7, 2025 14:20
@github-actions github-actions bot added documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX labels Dec 7, 2025
@dkleinF5 dkleinF5 marked this pull request as ready for review December 8, 2025 07:13
@dkleinF5 dkleinF5 marked this pull request as draft December 8, 2025 07:14
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1545/

@dkleinF5 dkleinF5 force-pushed the waf/update-external-references branch 5 times, most recently from cbffb3c to 7119d5e Compare December 15, 2025 09:17
@dkleinF5 dkleinF5 force-pushed the waf/update-external-references branch from 7119d5e to b136813 Compare December 18, 2025 09:19
@dkleinF5 dkleinF5 force-pushed the waf/update-external-references branch from b136813 to d37773b Compare January 22, 2026 08:26
@ADubhlaoich ADubhlaoich marked this pull request as ready for review January 22, 2026 09:48
@dkleinF5 dkleinF5 self-assigned this Jan 22, 2026
@dkleinF5 dkleinF5 requested review from JTorreG and y82 January 22, 2026 12:15
@dkleinF5 dkleinF5 force-pushed the waf/update-external-references branch from d37773b to 7d2e902 Compare January 25, 2026 08:21
JTorreG
JTorreG reviewed Jan 26, 2026
View reviewed changes
JTorreG
JTorreG reviewed Jan 26, 2026
View reviewed changes
JTorreG
JTorreG reviewed Jan 26, 2026
View reviewed changes
JTorreG
JTorreG reviewed Jan 26, 2026
View reviewed changes
@dkleinF5 @JTorreG
Apply suggestions from code review
d1395e5 
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
@dkleinF5 dkleinF5 removed the request for review from y82 January 26, 2026 15:21
@dkleinF5 dkleinF5 merged commit f4e62b3 into main Jan 26, 2026
9 checks passed
@dkleinF5 dkleinF5 deleted the waf/update-external-references branch January 26, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@JTorreG JTorreG JTorreG approved these changes

Assignees

@dkleinF5 dkleinF5

Labels

documentation Improvements or additions to documentation product/waf Issues related to F5 WAF for NGINX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dkleinF5 @ADubhlaoich @JTorreG