Skip to content

Fix compilation issues on Windows#734

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

Fix compilation issues on Windows#734
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 22, 2024

I attempted to solve compilation issues on Windows and I have revised my PRs serveral times. Hopefully this will be my last revision, maybe...

The purpose of this PR is as follows.

Accoring MSDN and mingw-w64, snprintf() works properly now. In #718, I took mingw-w64-crt's implementation of snprintf(), but it unchanged here.

@wizzomafizzo
Copy link
Copy Markdown

@ikspress Hi. Do you have any build instructions for this branch? I'm pretty keen to try it out but I don't have much experience compiling in windows. Thanks for your work!

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 12, 2024

@ikspress Hi. Do you have any build instructions for this branch? I'm pretty keen to try it out but I don't have much experience compiling in windows. Thanks for your work!

Hi. Would you mind tell me what environment you are using? MSYS2, MSVC or others?
If you want to run libnfc under MSYS2, there is already a compilation script here. Please refer to readme. If not, please tell me what you are using. If you have any trouble, feel free to tell me what you need.

@ghost ghost force-pushed the win32-compilation branch from 58e2e3d to 087e24e Compare July 13, 2024 13:18
@ghost ghost force-pushed the win32-compilation branch from 087e24e to f54f591 Compare July 18, 2024 16:19
@ghost ghost closed this by deleting the head repository Apr 29, 2026
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conflicting macro definations in contrib/windows.h and errno.h

1 participant