-
Notifications
You must be signed in to change notification settings - Fork 20
runner.conda: Bump Micromamba from 1.5.8 → 2.1.0 #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
victorlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested alongside nextstrain/conda-base#108.
NEXTSTRAIN_CONDA_CHANNEL=nextstrain/label/pull-108 \
NEXTSTRAIN_CONDA_BASE_PACKAGE="nextstrain-base ==20250417T231442Z" \
./devel/venv-run nextstrain setup --force conda
Output:
Checking setup…
✔ yes: operating system is supported
✔ yes: Rosetta 2 is enabled
✔ yes: runtime data dir doesn't have spaces
✔ yes: runtime appears set up
✔ yes: snakemake is installed and runnable
✔ yes: augur is installed and runnable
✔ yes: auspice is installed and runnable
All good! Set up of conda complete.
This is needed for the CI workflow to complete successfully until nextstrain/cli#430 is merged and released.
|
I also tested locally to ensure that the |
Newer versions since 2.0.0 include fix for installing nextstrain/conda-base when the dependencies specify `x86_64-microarch-level`. Since we're bumping the version, might has well bump to the latest version. Skimmed over the mamba CHANGELOG from 1.5.1 to 2.1.0 and nothing jumped out to me. Resolves <#429>
a415700 to
db59660
Compare
|
What's the story for existing users here? If I understand correctly, they're going to run into errors during That feels somewhat crummy. I wonder if we can make it better. Some (very different) potential options I'd see are
Maybe y'all see other options? |
Yeah, this was my expected resolution for existing users. I didn't think 2 commands to resolve the issue would be too bad... Option (2) seems to work (nextstrain/conda-base#111), so I'd be inclined to go with that for now and revisit option (3) in the future if needed. |
|
+1 for option (2) for now and (3) not "if needed" but soon to follow. By the time we're doing (3), we'd want to have already done this Micromamba version bump. I'd also like to include logic with it to update Micromamba during
It's not that two commands themselves would be too onerous, but that the way folks will encounter the issue is that suddenly |
This is needed for the CI workflow to complete successfully until nextstrain/cli#430 is merged and released.
|
The issue this change was intended to help resolve was instead resolved without needing any updates to Nextstrain CLI itself. We should still bump Micromamba at some point, but it is no longer urgent. I would like to block bumping it on smoothing the upgrade process for existing runtime setups (as I described above). The work I did for upgrading/switching the Conda subdir used by the runtime (e.g. Marking this as draft for now. |
Description of proposed changes
Newer versions since 2.0.0 include fix for installing nextstrain/conda-base when the dependencies specify
x86_64-microarch-level.Related issue(s)
Resolves #429
Related to nextstrain/conda-base#105
Checklist