Fix Azure Batch startTask.script not executing when copyToolInstallMode=node#6864
Open
adamrtalbot wants to merge 3 commits intomasterfrom
Open
Fix Azure Batch startTask.script not executing when copyToolInstallMode=node#6864adamrtalbot wants to merge 3 commits intomasterfrom
adamrtalbot wants to merge 3 commits intomasterfrom
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
…de=node (#6863) Combine azcopy install and user script into a single bash -c invocation instead of joining two separate bash -c commands with &&, which caused the shell to misinterpret the command boundary and silently drop the user script. Generated by Claude Code Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
…rapping The createStartTask method wraps the user script in bash -c '...' but escaped single quotes by replacing ' with '' (two empty strings in bash) instead of the correct '\'' idiom (end quote, escaped literal quote, start quote). This caused scripts containing single quotes to be misparsed, silently breaking commands while the startTask still exited 0. Generated by Claude Code Signed-off-by: adamrtalbot <12817534+adamrtalbot@users.noreply.github.com>
adamrtalbot
force-pushed
the
fix/azure-batch-starttask-fix
branch
from
686f2d0 to
a0266f8
Compare
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
d9fa5cd to
d752bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6863
bash -cinvocation instead of joining two separatebash -ccommands with&&bash -c "..." && bash -c '...') caused the shell to misinterpret the command boundary due to mixed quoting, silently dropping the user'sstartTask.script&&, and wraps once:bash -c 'cmd1 && cmd2'Changes
AzBatchService.groovycreateStartTask(): collect raw commands (without individualbash -cwrappers), combine into a singlebash -c '...'invocation with proper single-quote escapingAzBatchServiceTest.groovyTesting
AzBatchServiceTesttests passstartTask.scriptnow executes correctly alongside azcopy install