Support for recurring tasks

[schulm]

Fixes #34

[raimund-schluessler]

Thanks a lot. This seems to be a new implementation, not based on #2318, right?

[schulm]

@raimund-schluessler Wasn't aware of #2318, its a new implementation, will add some a proper description later on, about how different tools (Thunderbird, Apple Calendar) are handling the recurring tasks, how this is done here. The markup part is mostly copied from the calendar.

[asavageiv]

Just loaded this manually and it seems to work on first impression. I'll let it run for a while to see if I find any issues. Thank you so so so much!

[tjbp]

Thanks, this has worked well in testing. However I get an error from the ical lib when End is On date, and when End is After the max occurrences appear to be ignored. Am happy to work on patches if useful.

[schulm]

@tjbp Can you elaborate on the error?

[tjbp]

@schulm error with stack trace.

[devn1x]

I also have a little bit of feedback regarding the selection dialog for reccurrence, if you are interested.

It would be pretty handy to have different parameters, depending on which type of reccurance you select. As inspiration I have also included examples from the Tasks.org Android app, which I personally find extraordinarily intuitive.

• Daily: I think this can stay as it is. It makes sense to just select the interval of days. Heres a screenshot for comparison:

• Weekly: I think it might make sense to allow the user to additionally select the specific weekdays, on which the Task should reoccur.

• Monthly: Maybe allow the user to select the day of the month this should reoccur or (if its not too complex) even something like every 3rd wednesday of the month.

• Yearly: Nothing to add here as well.

This is my opinion at least, but I am open to discuss this further. And of course, thanks for working on this!

[schulm]

@devn1x @tjbp @asavageiv
I have fixed some issues with the number of occurence and also aligned the UI to the one of the calendar. Happy to get some feedback

[provokateurin]

@schulm you should not add the translations yourself, the translation community will do this automatically once this PR is merged. Also I assume that they are AI generated, which can often lead to wrong translations due to missing context.

[raimund-schluessler]

@schulm you should not add the translations yourself, the translation community will do this automatically once this PR is merged. Also I assume that they are AI generated, which can often lead to wrong translations due to missing context.

Correct, translations are handled on Transifex and synced to the repo automatically once the PR is merged.
Please just make sure they reference the correct app, so t('tasks', ... instead of t('calendar', ... (see my suggested change above).

[schulm]

So I just revert my changes from in l10n/? @raimund-schluessler

[raimund-schluessler]

So I just revert my changes from in l10n/? @raimund-schluessler

Yes, you should drop all changes to the files in l10n. Thanks!

[provokateurin]

BTW if this duplicates code from the calendar app, it probably makes sense to talk to the Calendar app maintainers and create a shared library both apps can use.

[devn1x]

@schulm: I looked at it locally and at first glance it looks really good. If I had to say something regarding the ui, I would only mention that the alignment between components sometimes feels a little off. E.g. (maybe you wanted to push the dropdown to a new line?):

Sadly, I hadn't had the time to check it functionality wise.

But you see, this is now small stuff. I think it was a really good idea to copy the design from the calendar.

[schulm]

@devn1x This modal is now aligned with the calendar one.

[devn1x]

Nice. That looks better. While testing I noticed, that when I select the checkbox "On the", it shifts to the right. Before:

And after clicking:

I also have question. When you select "On the" first "day" like this, isn't this redundant to "On a specific day"? Although this applies to the calendar as well.

[schulm]

@devn1x
Added some css fixes, some items like the weekday/day of month and month selectors are now having 100% width

fixed the "On the" container (also full width)

Yes its redundand, but maybe you need the option for example for "every second to last day", so it will work for month with different lengths...

[devn1x]

@schulm

Oh right, that could indeed be helpful.

Thanks. I tested again with the latest version and now it behaves like this, which is rather interesting:
screen_recording.webm

[schulm]

@devn1x That doesn't look like my current changes, the list of days should have full width. Maybe a browser cache issue?

[devn1x]

Oh sorry, you are right. Now it looks better. Thanks!

It seems there is nothing that jumps out at me right now.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[devn1x]

@schulm
I discovered some other probably unintended behaviour (I didn't show it in the video, but they where both shown at the start):
screen_recording.webm

Otherwise, I also had another idea for possible improvement. In my use cases, it's really helpful to identify recurring Tasks in the list view at a glance. Maybe it would make sense to add some kind of indicator in the list of tasks. Maybe like the icon that gets displayed, when the description is filled? What do you think?

[schulm]

@devn1x I've changed the visibility of the RecurrenceItem in the sidebar, its only visible if a task has a start date, this is also done by other task apps. Also I've added a recurring icon in the task list.

Update: there is still somehow an issue there...