Skip to content

👇👇 Add message double tap action#5905

Open
AndyScherzinger wants to merge 2 commits intomasterfrom
feat/5240/messageDoubleTap
Open

👇👇 Add message double tap action#5905
AndyScherzinger wants to merge 2 commits intomasterfrom
feat/5240/messageDoubleTap

Conversation

@AndyScherzinger
Copy link
Member

Resolves #5240

... by adding a double tab calculating logic to chatkits listerner mechanism and for the long-press listener implementation on certain messages also replaces it with a gesture implementation handling long-press + doubleTap - in the later the double tab will not work if there is also a single tap logic i.e. when navigation via click on a reply section of a message.

Also had to extract/short some bind methods to resolve the newly caused detekt warnings to make the check turn green again

🚧 TODO

  • review/test/merge

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Feb 25, 2026
@AndyScherzinger AndyScherzinger added enhancement New feature or request 3. to review Waiting for reviews labels Feb 25, 2026
@AndyScherzinger AndyScherzinger review requested due to automatic review settings February 25, 2026 21:49
@AndyScherzinger AndyScherzinger force-pushed the feat/5240/messageDoubleTap branch from 8d134a9 to cc35c14 Compare February 25, 2026 21:49
@AndyScherzinger AndyScherzinger changed the title Add message double tap action 👇👇 Add message double tap action Feb 25, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/5240/messageDoubleTap branch from cc35c14 to e773bb0 Compare February 26, 2026 08:24
Resolves #5240

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…the chatkit click listeners

Resolves #5240

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/5240/messageDoubleTap branch from e773bb0 to a0f61e9 Compare February 28, 2026 08:49
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5905.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: chat 🗨️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double tap on message to react

1 participant