Open
Conversation
8d134a9 to
cc35c14
Compare
cc35c14 to
e773bb0
Compare
e773bb0 to
a0f61e9
Compare
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5905.apk |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #5240
... by adding a double tab calculating logic to chatkits listerner mechanism and for the long-press listener implementation on certain messages also replaces it with a gesture implementation handling long-press + doubleTap - in the later the double tab will not work if there is also a single tap logic i.e. when navigation via click on a reply section of a message.
Also had to extract/short some bind methods to resolve the newly caused detekt warnings to make the check turn green again
🚧 TODO
🏁 Checklist
/backport to stable-xx.x