Skip to content

Conversation

@mahibi
Copy link
Collaborator

@mahibi mahibi commented Jan 12, 2026

see commit message

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

conversationUser must be known before continuing (see crash below)
Also minor refactoring.

Exception java.lang.NullPointerException:
  at com.nextcloud.talk.conversationinfo.ConversationInfoActivity.handleParticipants (ConversationInfoActivity.kt:812)
  at com.nextcloud.talk.conversationinfo.ConversationInfoActivity.access$handleParticipants (ConversationInfoActivity.kt:117)
  at com.nextcloud.talk.conversationinfo.ConversationInfoActivity$getListOfParticipants$1.onNext (ConversationInfoActivity.kt:867)
  at com.nextcloud.talk.conversationinfo.ConversationInfoActivity$getListOfParticipants$1.onNext (ConversationInfoActivity.kt:860)
  at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.drainNormal (ObservableObserveOn.java:201)
  at io.reactivex.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.run (ObservableObserveOn.java:255)
  at io.reactivex.android.schedulers.HandlerScheduler$ScheduledRunnable.run (HandlerScheduler.java:124)
  at android.os.Handler.handleCallback (Handler.java:942)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:211)
  at android.os.Looper.loop (Looper.java:300)
  at android.app.ActivityThread.main (ActivityThread.java:8227)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:580)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1028)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added this to the 23.0.0 milestone Jan 12, 2026
@mahibi mahibi self-assigned this Jan 12, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label Jan 12, 2026
@mahibi
Copy link
Collaborator Author

mahibi commented Jan 12, 2026

/backport to stable-22.1

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5692.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings100100
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@mahibi mahibi merged commit 732f677 into master Jan 13, 2026
18 of 19 checks passed
@mahibi mahibi deleted the bugfix/noid/fixNpeInConversationInfoActivity branch January 13, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants