feat: lazy initialization for editor setup #2212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjeck
commented
Dec 9, 2025
| Util::addStyle(Application::APP_ID, 'grid'); | ||
| Util::addStyle(Application::APP_ID, 'modal'); | ||
| Util::addStyle(Application::APP_ID, 'tiptap'); | ||
| Util::addStyle(Application::APP_ID, 'tables-style'); |
Contributor
Author
There was a problem hiding this comment.
unrelated to this feature, just removing since not needed
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
juliusknorr
reviewed
Jan 9, 2026
| if (this.initialized) return | ||
| // Prefer initializing when the editor wrapper enters the viewport | ||
| if ('IntersectionObserver' in window) { |
Member
There was a problem hiding this comment.
Should be fine to assume that intersection observer is widely available https://caniuse.com/intersectionobserver
juliusknorr
approved these changes
Jan 9, 2026
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Generally fine, but i think we can simplify it and drop the fallback case
Member
|
Ci also needs some work to pass ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2174
When there are many rich text cells, the page lags and while each editor is being loaded. This improves performance by only loading the cell when it's scrolled into the user's view