Skip to content

feat: add noise-supression to calls#17335

Merged
nickvergessen merged 7 commits intomainfrom
feat/3252/noise-cancellation--calls
Apr 2, 2026
Merged

feat: add noise-supression to calls#17335
nickvergessen merged 7 commits intomainfrom
feat/3252/noise-cancellation--calls

Conversation

@Antreesy
Copy link
Copy Markdown
Contributor

@Antreesy Antreesy commented Mar 10, 2026 •
edited
Loading

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Reusing the same toggle as was implemented for voice message
image
Other changes are only noticeable on audio receiver side

🚧 Tasks

  • Code review
  • Live test in call with real people (everyone's with mic on)
  • Test with different browser engines (in case of unsupported features)
    • audioContext.resume() and user gestures
  • Check for old browsers, if need a fallback
    • Mobile browsers esp.
  • Visuals (to reflect enhanced noise suppression somehow (second SpeakingMonitor?)

⏩ Follow-ups

  • Adjust description wording (first toggle to "Reduce background noise" and the second toggle to "Remove background noise for better voice quality")
  • Merge suppression toggles into one?
  • Or do a radio group e.g. with "None/Basic/Enhanced" as the options
  • Add mic test with instant feedback to the user?

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🏖️ Next Major (34) milestone Mar 10, 2026
@Antreesy Antreesy requested a review from danxuliu March 10, 2026 18:18
@Antreesy Antreesy self-assigned this Mar 10, 2026
@Antreesy Antreesy force-pushed the feat/3252/noise-cancellation--sapphi branch from 710057b to 9ff4d80 Compare March 11, 2026 15:51
@Antreesy Antreesy force-pushed the feat/3252/noise-cancellation--calls branch 2 times, most recently from 944f477 to 889fb8b Compare March 11, 2026 16:10
Base automatically changed from feat/3252/noise-cancellation--sapphi to main March 12, 2026 11:08
@Antreesy Antreesy force-pushed the feat/3252/noise-cancellation--calls branch 2 times, most recently from 588592e to 73be52b Compare March 17, 2026 18:07
@Antreesy Antreesy marked this pull request as ready for review March 17, 2026 18:07
DorraJaouad
DorraJaouad reviewed Mar 18, 2026
View reviewed changes
Comment thread src/utils/media/pipeline/NoiseSuppressor.js
Comment thread src/utils/suppressNoise.ts Outdated
Comment thread src/utils/media/pipeline/NoiseSuppressor.js Outdated
Comment thread src/utils/media/pipeline/NoiseSuppressor.js
Comment thread src/utils/webrtc/MediaDevicesManager.js Outdated
DorraJaouad
DorraJaouad reviewed Apr 1, 2026
View reviewed changes
Comment thread src/utils/webrtc/MediaDevicesManager.js Outdated
Comment thread src/utils/suppressNoise.ts
Comment thread src/utils/suppressNoise.ts
Antreesy added 7 commits April 2, 2026 12:12
@Antreesy
fix: disable native browser audio handling when RNNoise model is in p…
2433691 
…lace

- noiseSuppression might interfere with trained model
- autoGainControl might grow exponentially with reduced noise

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(suppressNoise): add gain node to the pipeline to increase the out…
25c5ae1 
…put volume

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
feat: implement NoiseSuppressor node for audio processing
4827c7d 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: cleanup unused nodes, keep only one set per consumer
226c530 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: better error handling for registering worklets
45581d7 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: attempt to resume existing context
1567dbb 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix: better clean up on node processor
dd8614c 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feat/3252/noise-cancellation--calls branch from 7cd4e53 to dd8614c Compare April 2, 2026 10:12
DorraJaouad
DorraJaouad approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. All works as expected.

@nickvergessen nickvergessen merged commit 12f42bf into main Apr 2, 2026
54 checks passed
@nickvergessen nickvergessen deleted the feat/3252/noise-cancellation--calls branch April 2, 2026 14:22
@Antreesy
Copy link
Copy Markdown
Contributor Author

Antreesy commented Apr 2, 2026

@danxuliu still waiting for your follow-up review, when you're back =)

@Antreesy Antreesy mentioned this pull request Apr 9, 2026
Open
14 tasks
Antreesy added a commit that referenced this pull request Apr 14, 2026
@Antreesy
revert: "feat: add noise-supression to calls" #17335
b023225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@Antreesy Antreesy

Labels

enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

🏖️ Next Major (34)

Development

Successfully merging this pull request may close these issues.

🎙️ Noise suppression with a model

3 participants

@Antreesy @DorraJaouad @nickvergessen