refactor: remove deprecated calls to IConfig::getAppValue#17171
Draft
miaulalala wants to merge 1 commit intomainfrom
Draft
refactor: remove deprecated calls to IConfig::getAppValue#17171miaulalala wants to merge 1 commit intomainfrom
miaulalala wants to merge 1 commit intomainfrom
Conversation
| $groups = $this->config->getAppValue('spreed', 'allowed_groups', '[]'); | ||
| $groups = json_decode($groups, true); | ||
| return \is_array($groups) ? $groups : []; | ||
| $groups = $this->appConfig->getAppValueArray('allowed_groups'); |
Member
There was a problem hiding this comment.
We should document the types and included changed defaults in the settings.md
Contributor
Author
There was a problem hiding this comment.
but the setter didn't change?
Member
There was a problem hiding this comment.
Well we should use the same type in get and set, otherwise this is "based on assumptions that might change".
Contributor
Author
There was a problem hiding this comment.
ah I see, fair enough. I just figured your comment in #17171 (comment) was meant to point me towards using getArrayValue
miaulalala
force-pushed
the
refactor/noid/remove-deprecated-config-app-calls
branch
from
0bdd092 to
bb2ab2c
Compare
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
refactor/noid/remove-deprecated-config-app-calls
branch
from
bb2ab2c to
1adc137
Compare
Contributor
Author
|
to do: do the config values one by one and change settings itself, the documentation, the occ config options and every part of the code where the config options is written or read. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix:
🏁 Checklist
docs/has been updated or is not required