Skip to content

fix: provide canDownload helper for shares and use it where appropriate#59008

Merged
susnux merged 2 commits intomasterfrom
federated-sharing-check
Mar 17, 2026
Merged

fix: provide canDownload helper for shares and use it where appropriate#59008
susnux merged 2 commits intomasterfrom
federated-sharing-check

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 17, 2026

Summary

Use consistent logic for checking permissions of shares

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 34 milestone Mar 17, 2026
@susnux susnux requested a review from a team as a code owner March 17, 2026 16:04
@susnux susnux added the bug label Mar 17, 2026
@susnux susnux requested review from icewind1991 and removed request for a team March 17, 2026 16:04
@susnux susnux added the 3. to review Waiting for reviews label Mar 17, 2026
@susnux
Copy link
Contributor Author

susnux commented Mar 17, 2026

/backport to stable32

@susnux
Copy link
Contributor Author

susnux commented Mar 17, 2026

/backport to stable33

@susnux susnux self-assigned this Mar 17, 2026
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the federated-sharing-check branch from 2573d03 to 7f8f86a Compare March 17, 2026 16:23
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux merged commit 22976d2 into master Mar 17, 2026
195 of 199 checks passed
@susnux susnux deleted the federated-sharing-check branch March 17, 2026 21:57
@backportbot
Copy link

backportbot bot commented Mar 17, 2026

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/59008/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 08495bfc 7f8f86ab

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/59008/stable33

Error: Failed to push branch backport/59008/stable33: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux
Copy link
Contributor Author

susnux commented Mar 17, 2026

/backport to stable31

@susnux
Copy link
Contributor Author

susnux commented Mar 17, 2026

/backport to stable33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants