Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
…r might on another server Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if ($send) { | ||
| $ownerCloudId = $this->cloudIdManager->getCloudId($remoteShare['owner'], $remoteShare['remote']); | ||
| $shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_' . time(), $shareType, $expirationDate); | ||
| [$token, $remoteId] = $this->notifications->requestReShare( |
Check failure
Code scanning / Psalm
TooManyArguments Error
There was a problem hiding this comment.
Some changes may be missing, the shareType param is not in requestReShare
| $this->storeRemoteId($shareId, $remoteId); | ||
| } else { | ||
| $this->removeShareFromTable($share); | ||
| $this->removeShareFromTable($shareId); |
Check failure
Code scanning / Psalm
InvalidScalarArgument Error
|
|
||
| if ($failure) { | ||
| $this->removeShareFromTableById($shareId); | ||
| $this->removeShareFromTable($shareId); |
Check failure
Code scanning / Psalm
InvalidScalarArgument Error
| } | ||
| if ($send) { | ||
| $ownerCloudId = $this->cloudIdManager->getCloudId($remoteShare['owner'], $remoteShare['remote']); | ||
| $shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_' . time(), $shareType, $expirationDate); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
There was a problem hiding this comment.
The expiration column is nullable so null is acceptable, provided that createNamedParameter handles this correctly.
| if ($send) { | ||
| $ownerCloudId = $this->cloudIdManager->getCloudId($remoteShare['owner'], $remoteShare['remote']); | ||
| $shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_' . time(), $shareType, $expirationDate); | ||
| [$token, $remoteId] = $this->notifications->requestReShare( |
Check notice
Code scanning / Psalm
PossiblyInvalidArrayAccess Note
| if ($send) { | ||
| $ownerCloudId = $this->cloudIdManager->getCloudId($remoteShare['owner'], $remoteShare['remote']); | ||
| $shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_' . time(), $shareType, $expirationDate); | ||
| [$token, $remoteId] = $this->notifications->requestReShare( |
Check notice
Code scanning / Psalm
PossiblyInvalidArrayAccess Note
| [$token, $remoteId] = $this->notifications->requestReShare( | ||
| $remoteShare['share_token'], | ||
| $remoteShare['remote_id'], | ||
| $shareId, |
Check notice
Code scanning / Psalm
InvalidArgument Note
|
Same issue here with the share ID being int instead of string. |
| } | ||
| if ($send) { | ||
| $ownerCloudId = $this->cloudIdManager->getCloudId($remoteShare['owner'], $remoteShare['remote']); | ||
| $shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_' . time(), $shareType, $expirationDate); |
There was a problem hiding this comment.
The expiration column is nullable so null is acceptable, provided that createNamedParameter handles this correctly.
| if ($send) { | ||
| $ownerCloudId = $this->cloudIdManager->getCloudId($remoteShare['owner'], $remoteShare['remote']); | ||
| $shareId = $this->addShareToDB($itemSource, $itemType, $shareWith, $sharedBy, $ownerCloudId->getId(), $permissions, 'tmp_token_' . time(), $shareType, $expirationDate); | ||
| [$token, $remoteId] = $this->notifications->requestReShare( |
There was a problem hiding this comment.
Some changes may be missing, the shareType param is not in requestReShare
2 participants
Manual backport of #58689