Unified search: Files provider adds favorite state#58980
Open
tobiasKaminsky wants to merge 1 commit intomasterfrom
Open
Unified search: Files provider adds favorite state#58980tobiasKaminsky wants to merge 1 commit intomasterfrom
tobiasKaminsky wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
requested review from
ArtificialOwl,
come-nc,
icewind1991 and
sorbaugh
and removed request for
a team
Member
Author
|
This is c&p from CollectionPhoto.php:76 |
come-nc
reviewed
Mar 17, 2026
| ); | ||
| } | ||
|
|
||
| private function isFavorite(string $fileId): bool { |
Contributor
There was a problem hiding this comment.
Suggested change
| private function isFavorite(string $fileId): bool { | |
| private function isFavorite(int $fileId): bool { |
| ); | ||
| $searchResultEntry->addAttribute('fileId', (string)$result->getId()); | ||
| $searchResultEntry->addAttribute('path', $path); | ||
| $searchResultEntry->addAttribute('favorite', $this->isFavorite((string)$result->getId()) ? "true" : "false"); |
Contributor
There was a problem hiding this comment.
Suggested change
| $searchResultEntry->addAttribute('favorite', $this->isFavorite((string)$result->getId()) ? "true" : "false"); | |
| $searchResultEntry->addAttribute('favorite', $this->isFavorite($result->getId()) ? "true" : "false"); |
| } | ||
|
|
||
| private function isFavorite(string $fileId): bool { | ||
| $tagManager = \OCP\Server::get(\OCP\ITagManager::class); |
Contributor
There was a problem hiding this comment.
Should be injected in the constructor instead.
| } | ||
| $tags = $tagger->getTagsForObjects([$fileId]); | ||
|
|
||
| if ($tags === false || empty($tags)) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ($tags === false || empty($tags)) { | |
| if ($tags === false || empty($tags[$fileId])) { |
| return false; | ||
| } | ||
|
|
||
| return array_search(ITags::TAG_FAVORITE, current($tags)) !== false; |
Contributor
There was a problem hiding this comment.
Suggested change
| return array_search(ITags::TAG_FAVORITE, current($tags)) !== false; | |
| return array_search(ITags::TAG_FAVORITE, $tags[$fileId]) !== false; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)