feat(files_versions): Auto-reload versions tab on file#57843
Draft
silverkszlo wants to merge 1 commit intomasterfrom
Draft
feat(files_versions): Auto-reload versions tab on file#57843silverkszlo wants to merge 1 commit intomasterfrom
silverkszlo wants to merge 1 commit intomasterfrom
Conversation
Listen for files:node:updated events and automatically refresh the versions list when the current file is saved, eliminating the need to manually close and reopen the sidebar to see new versions. Signed-off-by: silver <s.szmajduch@posteo.de>
juliusknorr
reviewed
Jan 27, 2026
| // Delay to let the server create the new version | ||
| setTimeout(() => { | ||
| reloadVersions() | ||
| }, 1000) |
Member
There was a problem hiding this comment.
Now reading this, I'm unsure if the UI_Save post message is the right one as I would expect that once we receive the save success from Collabora we should not need to wait anymore.
Can you check if Action_Save_Resp does get emitted as well?
Author
There was a problem hiding this comment.
So I checked with added console logs and definitely did not get Action_Save_Resp:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds automatic reloading of the versions sidebar tab when documents are saved, eliminating the need for manual refresh to see new versions. The feature listens to
files:node:updatedevents.Changes
files:node:updatedevents inFilesVersionsSidebarTab.vueinfiles_versionsKnown Testing Limitation
However, the implementation has been verified using alternative methods:
files:node:updatedshows events are correctly emitted after savesConsole Logging for Testing
When testing/reviewing, console output will show:
This confirms:
Testing (once sidebar bug is fixed)
Once the sidebar UX issue is resolved, testing steps:
Note on Event Emission
Apps need to properly emit
files:node:updatedevents after saving for this feature to work.TODO
Checklist
3. to review, feature component)stable32)