Skip to content

Backport changes from my recent Passman fork#856

Draft
binsky08 wants to merge 17 commits into
masterfrom
feature/merge-fork
Draft

Backport changes from my recent Passman fork#856
binsky08 wants to merge 17 commits into
masterfrom
feature/merge-fork

Conversation

@binsky08
Copy link
Copy Markdown
Collaborator

@binsky08 binsky08 commented May 25, 2026 •
edited
Loading

Relevant changes summary:

  • use constants providing the app id, needed in the app's frontend and backend
  • setup sonarqube github action
  • remove duplicate scss code
  • remove unused constructor properties
  • remove duplicate function getCredentialAclForUser (that was exactly the same as getACL)
  • add compatibility for the new template script syntax to our Gruntfile.js

binsky08 added 17 commits May 25, 2026 16:50
@binsky08
update gitignore, add vendor and composer.lock
bab4edc 
Signed-off-by: binsky <timo@binsky.org>
@binsky08
use constants providing the app id needed in the app's frontend and b…
e42ad3a 
…ackend
@binsky08
setup sonarqube github action
6436d29 
Signed-off-by: binsky <timo@binsky.org>
@binsky08
exclude l10n and tests from sonar sources
070cef6 
Signed-off-by: binsky <timo@binsky.org>
@binsky08
ignore hardcoded credential detection in l10n due to a lot of false p…
52aa05b 
…ositives

Signed-off-by: binsky <timo@binsky.org>
@binsky08
ignore css directory in sonar analysis since it contains only compile…
dd7187a 
…d scss or external css
@binsky08
explicitly mention the visibility of method in NotificationService.ph…
e912fab 
…p; add new constant
@binsky08
remove duplicate scss code
e3699e8
@binsky08
remove unused constructor properties; add comments to empty catch blocks
2ab71e5
@binsky08
rename this parameter "$IManager" to "$manager"
d177a63
@binsky08
remove duplicate function getCredentialAclForUser (that was exactly t…
9e8f01a 
…he same as getACL)
@binsky08
fix service registration in OCA\PassmanNext\AppInfo\Application
8cfe13a
@binsky08
use the app id as our new settings section identifier
7398874
@binsky08
add compatibility for the new template script syntax to our Gruntfile.js
756c90b
@binsky08
update auto-generated css files
e8c6fa6
@binsky08
migrate missed app id 'passman' occurrences to Application::APP_ID
f33aee4
@binsky08
fix app naming from fork backport
153a795
@binsky08 binsky08 requested a review from animalillo May 25, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@animalillo animalillo Awaiting requested review from animalillo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@binsky08