Fix backup cache handling when JSON decode returns null#2105
Open
Dominik0101 wants to merge 1 commit intonextcloud:masterfrom
Open
Fix backup cache handling when JSON decode returns null#2105Dominik0101 wants to merge 1 commit intonextcloud:masterfrom
Dominik0101 wants to merge 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: Dominik_Kessler <dominikkessler103@gmail.com>
91323d4 to
1b1154a
Compare
Author
|
The issue can be reproduced by opening the backups section in the NextcloudPi admin panel. If the cache file contains invalid or empty JSON, the page fails with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backups page can crash when the cache file contains invalid or empty JSON.
This happens because json_decode($cache_str, true) may return null.
The previous implementation used
or [ ], which does not assign the fallback array as intended due to PHP operator precedence.This patch ensures that $cache is always initialized as an array:
This prevents runtime errors when accessing the cache.