Skip to content

fix(OutOfOfficeForm): datepicker overlapping with sidebar#12303

Merged
GVodyanov merged 1 commit intomainfrom
fix/overlapping-datepicker-in-ooo
Feb 23, 2026
Merged

fix(OutOfOfficeForm): datepicker overlapping with sidebar#12303
GVodyanov merged 1 commit intomainfrom
fix/overlapping-datepicker-in-ooo

Conversation

@GVodyanov
Copy link
Copy Markdown
Contributor

This is being caused by the main view of the settings having its overflow hidden by the sidebar, and the popup of the datepicker is contained inside the main view and isn't appended somewhere later in the DOM

The ideal solution here would be to have the popup somewhere else where it isn't constrained, but seeing as it comes from a third party library I don't know what we can do about that.

Before After
image swappy-20260123_131330

Copy link
Copy Markdown
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is being caused by the main view of the settings having its overflow hidden by the sidebar

Out of curiosity, would lifting this in the upstream component be a problem? I assume any other floating elements inside settings are currently prone to a cut-off.

Comment thread src/components/OutOfOfficeForm.vue Outdated

#ooo-first-day {
:deep(.mx-datepicker-popup) {
left: 0 !important;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stylelint wants inset-inline-start. guess that make sense if the input is on the right in RTL mode

@hamza221
Copy link
Copy Markdown
Contributor

You can run npm run stylelint:fix

@hamza221 hamza221 added the bug label Jan 31, 2026
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
@GVodyanov GVodyanov force-pushed the fix/overlapping-datepicker-in-ooo branch from 8bb43c0 to e92759d Compare February 23, 2026 17:32
@GVodyanov
Copy link
Copy Markdown
Contributor Author

LGTM

This is being caused by the main view of the settings having its overflow hidden by the sidebar

Out of curiosity, would lifting this in the upstream component be a problem? I assume any other floating elements inside settings are currently prone to a cut-off.

I'm not sure this would work well with all dimensions of popups, if you have a really wide one it might be necessary to have it be translated to the left, also this is only an issue specifically with the datepicker component because of this:

The ideal solution here would be to have the popup somewhere else where it isn't constrained, but seeing as it comes from a third party library I don't know what we can do about that.

@GVodyanov GVodyanov merged commit afdf3a1 into main Feb 23, 2026
39 checks passed
@GVodyanov GVodyanov deleted the fix/overlapping-datepicker-in-ooo branch February 23, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants