fix(OutOfOfficeForm): datepicker overlapping with sidebar#12303
fix(OutOfOfficeForm): datepicker overlapping with sidebar#12303
Conversation
ChristophWurst
left a comment
There was a problem hiding this comment.
LGTM
This is being caused by the main view of the settings having its overflow hidden by the sidebar
Out of curiosity, would lifting this in the upstream component be a problem? I assume any other floating elements inside settings are currently prone to a cut-off.
|
|
||
| #ooo-first-day { | ||
| :deep(.mx-datepicker-popup) { | ||
| left: 0 !important; |
There was a problem hiding this comment.
stylelint wants inset-inline-start. guess that make sense if the input is on the right in RTL mode
|
You can run |
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
8bb43c0 to
e92759d
Compare
I'm not sure this would work well with all dimensions of popups, if you have a really wide one it might be necessary to have it be translated to the left, also this is only an issue specifically with the datepicker component because of this:
|
This is being caused by the main view of the settings having its overflow hidden by the sidebar, and the popup of the datepicker is contained inside the main view and isn't appended somewhere later in the DOM
The ideal solution here would be to have the popup somewhere else where it isn't constrained, but seeing as it comes from a third party library I don't know what we can do about that.