Skip to content

CI: fix env not being passed on matrix notification URL #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saw-jan merged 1 commit into from
Jan 20, 2026
Merged

CI: fix env not being passed on matrix notification URL #946

saw-jan merged 1 commit into from
Jan 20, 2026

Conversation

@nabim777
Copy link
Collaborator

@nabim777 nabim777 commented Jan 20, 2026 •
edited
Loading

Description

There was an issue with the matrix notification URL where the environment value was not being passed. So, this pr fixes that issue

Related Issue or Workpackage

  • Fixes <issue_link>

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@nabim777 nabim777 marked this pull request as ready for review January 20, 2026 04:09
@nabim777 nabim777 self-assigned this Jan 20, 2026
@nabim777 nabim777 changed the title CI: fix env not being passed on URL CI: fix env not being passed on matrix notification URL Jan 20, 2026
saw-jan
saw-jan reviewed Jan 20, 2026
View reviewed changes
saw-jan
saw-jan reviewed Jan 20, 2026
View reviewed changes
@nabim777
CI: fix env not being passed on URL
aabf13b 
Signed-off-by: nabim777 <nabinalemagar019@gmail.com>
@saw-jan saw-jan merged commit 5be2bc9 into master Jan 20, 2026
2 checks passed
@saw-jan saw-jan deleted the fix-ci branch January 20, 2026 07:18
This was referenced Jan 20, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saw-jan saw-jan saw-jan approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc julien-nc is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@ba1ash ba1ash Awaiting requested review from ba1ash ba1ash is a code owner

@dominic-braeunlein dominic-braeunlein Awaiting requested review from dominic-braeunlein dominic-braeunlein is a code owner

@Kharonus Kharonus Awaiting requested review from Kharonus Kharonus is a code owner

@lindenthal lindenthal Awaiting requested review from lindenthal lindenthal is a code owner

@psatyal psatyal Awaiting requested review from psatyal psatyal is a code owner

@wielinde wielinde Awaiting requested review from wielinde wielinde is a code owner

@NobodysNightmare NobodysNightmare Awaiting requested review from NobodysNightmare NobodysNightmare is a code owner

Assignees

@nabim777 nabim777

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nabim777 @saw-jan