Skip to content

fix: replace icon components with NcIconSvgWrapper #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chartman123 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

fix: replace icon components with NcIconSvgWrapper #3352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/Questions/QuestionRanking.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,14 @@
class="ranking-item__drag-handle"
variant="tertiary-no-background">
<template #icon>
<IconDragIndicator :size="20" />
<NcIconSvgWrapper :svg="IconDragIndicator" />
</template>
<NcActionButton
ref="buttonOptionUp"
:disabled="index === 0"
@click="onMoveUp(index)">
<template #icon>
<IconArrowUp :size="20" />
<NcIconSvgWrapper :svg="IconArrowUp" />
</template>
{{ t('forms', 'Move option up') }}
</NcActionButton>
Expand All @@ -96,7 +96,7 @@
:disabled="index === rankedOptions.length - 1"
@click="onMoveDown(index)">
<template #icon>
<IconArrowDown :size="20" />
<NcIconSvgWrapper :svg="IconArrowDown" />
</template>
{{ t('forms', 'Move option down') }}
</NcActionButton>
Expand All @@ -108,7 +108,7 @@
:ariaLabel="t('forms', 'Remove from ranking')"
@click="unrankOption(option)">
<template #icon>
<IconClose :size="20" />
<NcIconSvgWrapper :svg="IconClose" />
</template>
</NcButton>
</div>
Expand Down
Loading