Skip to content

[stable33] fix: properly handle closing the modal #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Feb 2, 2026
Merged

[stable33] fix: properly handle closing the modal #1920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d726a2d
fix: properly handle closing the modal
susnux Feb 2, 2026
c3c8114
chore(assets): Recompile assets
nextcloud-command Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/firstrunwizard-style.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/firstrunwizard-about.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=[window.OC.filePath('firstrunwizard', '', 'js/main-Boglr2q8.chunk.mjs'),window.OC.filePath('firstrunwizard', '', 'js/NcModal-PlfVmTTk-B-YiYR35.chunk.mjs'),window.OC.filePath('firstrunwizard', '', 'js/index-EKlYWjzp.chunk.mjs')])))=>i.map(i=>d[i]);
import{_ as u}from"./modulepreload-polyfill-CBWYtosv.chunk.mjs";import{s as i}from"./index-EKlYWjzp.chunk.mjs";document.addEventListener("DOMContentLoaded",function(){const e=()=>document.querySelector("#firstrunwizard_about"),t=()=>{e().addEventListener("click",async function(o){o.stopPropagation(),o.preventDefault();const n=document.querySelector('[aria-controls="header-menu-user-menu"]')??void 0,{open:r}=await u(async()=>{const{open:a}=await import("./main-Boglr2q8.chunk.mjs");return{open:a}},__vite__mapDeps([0,1,2]),import.meta.url);r(n),OC.hideMenus(()=>!1)})};e()?t():i("core:user-menu:mounted",t)});
const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=[window.OC.filePath('firstrunwizard', '', 'js/main-ClTfpjf9.chunk.mjs'),window.OC.filePath('firstrunwizard', '', 'js/NcModal-PlfVmTTk-B-YiYR35.chunk.mjs'),window.OC.filePath('firstrunwizard', '', 'js/index-EKlYWjzp.chunk.mjs')])))=>i.map(i=>d[i]);
import{_ as u}from"./modulepreload-polyfill-CBWYtosv.chunk.mjs";import{s as i}from"./index-EKlYWjzp.chunk.mjs";document.addEventListener("DOMContentLoaded",function(){const e=()=>document.querySelector("#firstrunwizard_about"),t=()=>{e().addEventListener("click",async function(o){o.stopPropagation(),o.preventDefault();const n=document.querySelector('[aria-controls="header-menu-user-menu"]')??void 0,{open:r}=await u(async()=>{const{open:a}=await import("./main-ClTfpjf9.chunk.mjs");return{open:a}},__vite__mapDeps([0,1,2]),import.meta.url);r(n),OC.hideMenus(()=>!1)})};e()?t():i("core:user-menu:mounted",t)});
//# sourceMappingURL=firstrunwizard-about.mjs.map
4 changes: 2 additions & 2 deletions js/firstrunwizard-activate.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=[window.OC.filePath('firstrunwizard', '', 'js/main-Boglr2q8.chunk.mjs'),window.OC.filePath('firstrunwizard', '', 'js/NcModal-PlfVmTTk-B-YiYR35.chunk.mjs'),window.OC.filePath('firstrunwizard', '', 'js/index-EKlYWjzp.chunk.mjs')])))=>i.map(i=>d[i]);
import{_ as t}from"./modulepreload-polyfill-CBWYtosv.chunk.mjs";document.addEventListener("DOMContentLoaded",async function(){(await t(()=>import("./main-Boglr2q8.chunk.mjs"),__vite__mapDeps([0,1,2]),import.meta.url)).open()});
const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=[window.OC.filePath('firstrunwizard', '', 'js/main-ClTfpjf9.chunk.mjs'),window.OC.filePath('firstrunwizard', '', 'js/NcModal-PlfVmTTk-B-YiYR35.chunk.mjs'),window.OC.filePath('firstrunwizard', '', 'js/index-EKlYWjzp.chunk.mjs')])))=>i.map(i=>d[i]);
import{_ as t}from"./modulepreload-polyfill-CBWYtosv.chunk.mjs";document.addEventListener("DOMContentLoaded",async function(){(await t(()=>import("./main-ClTfpjf9.chunk.mjs"),__vite__mapDeps([0,1,2]),import.meta.url)).open()});
//# sourceMappingURL=firstrunwizard-activate.mjs.map
16 changes: 8 additions & 8 deletions js/main-Boglr2q8.chunk.mjs → js/main-ClTfpjf9.chunk.mjs
View file
Open in desktop

Large diffs are not rendered by default.

0 js/main-Boglr2q8.chunk.mjs.license → js/main-ClTfpjf9.chunk.mjs.license
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion js/main-Boglr2q8.chunk.mjs.map → js/main-ClTfpjf9.chunk.mjs.map
View file
Open in desktop

Large diffs are not rendered by default.

0 js/main-Boglr2q8.chunk.mjs.map.license → js/main-ClTfpjf9.chunk.mjs.map.license
View file
Open in desktop
File renamed without changes.
7 changes: 6 additions & 1 deletion src/components/SlideShow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ const props = defineProps<{
pages: IPage[]
}>()

defineEmits<{
const emit = defineEmits<{
close: []
}>()

Expand Down Expand Up @@ -146,6 +146,11 @@ watch(() => currentIndex.value, (newPage, oldPage) => {
* @param pageId ID of the page to got to
*/
function goToPage(pageId: string) {
if (pageId === 'close') {
// special case: close the wizard
emit('close')
return
}
const id = props.pages.findIndex((page) => page.id === pageId)
currentIndex.value = id
}
Expand Down
Loading