WIP: Feat/federation by grnd-alt · Pull Request #7330 · nextcloud/deck

grnd-alt · 2025-10-21T09:14:39Z

Checklist for federation features:

Out of scope for the first round

manage board (set color, change name etc.)
reshare incoming federated share
Attachments
Comments
List Activity on incoming federated shares
List Activity from federated users correctly

How to test this

with nextcloud-docker-dev

checkout server branch feat/deck-federation
checkout deck branch feat/federation
docker compose up -d nextcloud nextcloud2
wait for full startup
in the web ui:
- go administration settings > sharing
- under "Add trusted server" add http://nextcloud.local and http://nextcloud2.local respectively for the other instance
docker compose exec nextcloud occ app:enable deck && docker compose exec nextcloud2 occ app:enable deck
build deck: npm ci && npm run dev
docker compose exec -ti nextcloud occ background-job:worker
in a second terminal: docker compose exec -ti nextcloud2 occ background-job:worker
docker compose exec nextcloud occ federation:sync-addressbooks && docker compose exec nextcloud2 occ federation:sync-addressbooks
in the admin sharing settings the trusted server should show a check mark on both instances like this:

now federated users can be found when sharing a deck board

juliusknorr

3 more comments i had pending while we looked through it in the call

juliusknorr · 2025-10-21T18:16:35Z

lib/Migration/Version11001Date20251016122010.php

+		$schema = $schemaClosure();
+
+		$tableName = 'deck_boards_external';
+		if ($schema->hasTable($tableName)) {


We should put all db changes of this pr in one migration file before merging

juliusknorr · 2025-10-29T12:38:34Z

lib/Service/ExternalBoardService.php

+	}
+
+	public function getExternalBoardFromRemote(Board $localBoard):DataResponse {
+		$shareToken = $localBoard->getShareToken();


Probably safeguard that the board has a share token here, as we discussed in the call this is checked before in the controller but should be here as well in case this is used in other places

juliusknorr · 2025-10-29T12:41:27Z

lib/Service/ExternalBoardService.php

+	public function getExternalBoardFromRemote(Board $localBoard):DataResponse {
+		$shareToken = $localBoard->getShareToken();
+		$participantCloudId = $this->cloudIdManager->getCloudId($this->userId, null);
+		$ownerCloudId = $this->cloudIdManager->resolveCloudId($localBoard->getOwner());


Worth to double check the length of the owner column so we can properly fit any federated cloud ids in it

github-actions · 2025-11-03T11:59:59Z

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 83373 was 82774 (+0.72%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

github-actions · 2025-11-03T12:38:52Z

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 83371 was 82774 (+0.72%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

blizzz

Gives a good impression! 🙂

As discussed in the call:

naming of new controllers
updating cards
taking global admin federations settings into account as mandatory
(some code style nitpicks)

Signed-off-by: grnd-alt <github@belakkaf.net>

feat: set accessToken from FederationMiddleware Signed-off-by: grnd-alt <github@belakkaf.net>

Signed-off-by: grnd-alt <github@belakkaf.net>

Signed-off-by: grnd-alt <git@belakkaf.net>

lib/Federation/DeckFederationProxy.php

lib/Federation/DeckFederationProvider.php

src/components/navigation/AppNavigationBoard.vue

lib/Service/PermissionService.php

lib/Controller/BoardOcsController.php

lib/Service/BoardService.php

lib/Federation/DeckFederationProxy.php

benjaminfrueh · 2026-02-16T20:24:29Z

lib/Service/BoardService.php

+			$this->configService->ensureFederationEnabled();
+			$sharedBy = $this->userManager->get($this->userId);
+			$board = $this->find($boardId);
+			$token = $this->random->generate(32);


Nitpick: to follow nextcloud patterns, could consider moving this magic number into a const, maybe DeckFederationProvider::TOKEN_LENGTH and reuse it in the migrations too.

Signed-off-by: grnd-alt <git@belakkaf.net>

juliusknorr reviewed Oct 29, 2025

View reviewed changes

grnd-alt self-assigned this Oct 30, 2025

grnd-alt added this to 📝 Productivity team Oct 30, 2025

github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Oct 30, 2025

grnd-alt moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Productivity team Oct 30, 2025

grnd-alt force-pushed the feat/federation branch from 2a82fa8 to fcae61d Compare November 3, 2025 12:34

grnd-alt force-pushed the feat/federation branch 3 times, most recently from f36ef61 to 41b05a6 Compare November 15, 2025 17:08

grnd-alt force-pushed the feat/federation branch 2 times, most recently from 30048a0 to 1ba8c21 Compare February 4, 2026 09:24

grnd-alt force-pushed the feat/federation branch 2 times, most recently from 277a420 to 8587fb9 Compare February 10, 2026 12:31

blizzz reviewed Feb 16, 2026

View reviewed changes

grnd-alt requested review from benjaminfrueh February 16, 2026 13:52

grnd-alt and others added 12 commits February 16, 2026 16:08

feat: initiate remote share notifications

0099888

Signed-off-by: grnd-alt <github@belakkaf.net>

wip: show federated shares in navigation

e8efdc4

Signed-off-by: grnd-alt <github@belakkaf.net>

read-only federated boards

db83a44

Signed-off-by: grnd-alt <github@belakkaf.net>

feat: federated card creation

b1188db

feat: set accessToken from FederationMiddleware Signed-off-by: grnd-alt <github@belakkaf.net>

feat: map external boardIds back to internal ones for frontend

7584dba

Signed-off-by: grnd-alt <github@belakkaf.net>

fix: remote card creation

74d7ccb

Signed-off-by: grnd-alt <github@belakkaf.net>

feat: create stacks on remote share

a8961e9

Signed-off-by: grnd-alt <github@belakkaf.net>

feat: delete stacks on remote shares

d272bd7

Signed-off-by: grnd-alt <github@belakkaf.net>

add create to ocs board controller

cf5e9a6

Signed-off-by: grnd-alt <github@belakkaf.net>

feat: ocs endpoint for addAcl

5a5c586

Signed-off-by: grnd-alt <git@belakkaf.net>

feat: register deck resource type

381ea02

Signed-off-by: grnd-alt <git@belakkaf.net>

feat: introduce config value for federation

bf5624a

Signed-off-by: grnd-alt <git@belakkaf.net>

grnd-alt added 5 commits February 16, 2026 16:08

feat: feature flag for federation

35bb6f4

Signed-off-by: grnd-alt <git@belakkaf.net>

update acl on federated shares

9089ed5

Signed-off-by: grnd-alt <git@belakkaf.net>

chore: apply cs:fix

8724319

Signed-off-by: grnd-alt <git@belakkaf.net>

feat: resolve federated owners

f245bfd

Signed-off-by: grnd-alt <git@belakkaf.net>

fix(federation): check permission on local copy of boards

bf54b70

Signed-off-by: grnd-alt <git@belakkaf.net>

grnd-alt force-pushed the feat/federation branch from 8587fb9 to bf54b70 Compare February 16, 2026 15:09

grnd-alt added 3 commits February 16, 2026 16:57

chore: rename new controllers

fb9f2f0

Signed-off-by: grnd-alt <git@belakkaf.net>

fix: respect admin config values for federation

5d45699

Signed-off-by: grnd-alt <git@belakkaf.net>

fix: do not add default permissions to federated shares

9441fa7

Signed-off-by: grnd-alt <git@belakkaf.net>

benjaminfrueh reviewed Feb 16, 2026

View reviewed changes

grnd-alt force-pushed the feat/federation branch 4 times, most recently from bcd956d to 480e269 Compare February 17, 2026 12:07

chore: improve ci

17e7592

Signed-off-by: grnd-alt <git@belakkaf.net>

grnd-alt force-pushed the feat/federation branch from 480e269 to 17e7592 Compare February 17, 2026 13:00

chore: add reuse compliance headers

865cbb7

Signed-off-by: grnd-alt <git@belakkaf.net>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Feat/federation#7330

WIP: Feat/federation#7330
grnd-alt wants to merge 22 commits intomainfrom
feat/federation

grnd-alt commented Oct 21, 2025 •

edited

Loading

Uh oh!

juliusknorr left a comment

Uh oh!

juliusknorr Oct 21, 2025

Uh oh!

juliusknorr Oct 29, 2025

Uh oh!

juliusknorr Oct 29, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

blizzz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benjaminfrueh Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

grnd-alt commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Out of scope for the first round

How to test this

Uh oh!

juliusknorr left a comment

Choose a reason for hiding this comment

Uh oh!

juliusknorr Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

juliusknorr Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

juliusknorr Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

blizzz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benjaminfrueh Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

grnd-alt commented Oct 21, 2025 •

edited

Loading