-
Notifications
You must be signed in to change notification settings - Fork 310
fix: make bin icon red on button hover #6854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks a lot for handling the updates to the readme and such :) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Talk we always color-code the action "Delete conversation" red (which is also always last in the list, as all delete actions should be).
This would be nice to do elsewhere too since it not only makes it quick to find and easier to understand, but also very immediately reduces the list you have to scan by one if what you are looking for is not deletion.

I would say we should even put this in the components and/or design guidelines @marcoambrosini @nimishavijay?
Signed-off-by: Seth Falco <seth@falco.fun>
Signed-off-by: Seth Falco <seth@falco.fun>
5651ec5 to
978bf0e
Compare

Summary
The bin icon would only highlight in red when specifically hovered over the icon, when it should've probably been when hovered over the button.
This just fixes that!
Alternatively, it could be that the desired behavior is that the icon never change color at all. Let me know if so and I can amend the PR accordingly.
Screenshots
Before
before.mp4
After
after.mp4
Checklist
Chores
Also does a chore!
The image
ghcr.io/juliushaertl/nextcloud-dev-php81:latestis a 4xx error now.A maintainer of the project changed their GitHub username, which broke the command in the README for running the nextcloud-dev Docker container. This needs to have their up-to-date username in the image path.
While updating that, I also changed a few other references as well.