Skip to content

Conversation

@SethFalco
Copy link

@SethFalco SethFalco commented Mar 25, 2025

  • Resolves: N/A
  • Target version: main

Summary

The bin icon would only highlight in red when specifically hovered over the icon, when it should've probably been when hovered over the button.

This just fixes that!

Alternatively, it could be that the desired behavior is that the icon never change color at all. Let me know if so and I can amend the PR accordingly.

Screenshots

Before

before.mp4

After

after.mp4

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included — N/A
  • Documentation (manuals or wiki) has been updated or is not required - N/A

Chores

Also does a chore!

The image ghcr.io/juliushaertl/nextcloud-dev-php81:latest is a 4xx error now.

A maintainer of the project changed their GitHub username, which broke the command in the README for running the nextcloud-dev Docker container. This needs to have their up-to-date username in the image path.

While updating that, I also changed a few other references as well.

@elzody
Copy link
Contributor

elzody commented Mar 25, 2025

Thanks a lot for handling the updates to the readme and such :)
As for the icon maybe @nextcloud/designers could have a look and see which makes the most sense? I think for the most part our icons in the action menus like this are just white/black.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Talk we always color-code the action "Delete conversation" red (which is also always last in the list, as all delete actions should be).
This would be nice to do elsewhere too since it not only makes it quick to find and easier to understand, but also very immediately reduces the list you have to scan by one if what you are looking for is not deletion.
image

I would say we should even put this in the components and/or design guidelines @marcoambrosini @nimishavijay?

GitHub does the same btw with the comments menu:
image

@jancborchardt jancborchardt moved this to 📐 At design in 🖍 Design team Apr 14, 2025
@jancborchardt jancborchardt moved this from 📐 At design to 🏗️ At engineering in 🖍 Design team Apr 14, 2025
Signed-off-by: Seth Falco <seth@falco.fun>
Signed-off-by: Seth Falco <seth@falco.fun>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🏗️ At engineering

Development

Successfully merging this pull request may close these issues.

5 participants