Skip to content

Conversation

@max65482
Copy link
Contributor

@max65482 max65482 commented Jan 17, 2026

Fixes #4994 by decreasing debounce time from 500 ms to 250 ms.

Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
@max65482 max65482 force-pushed the fix/slow-reactivity-issue branch from 00250a8 to caf81ef Compare January 17, 2026 18:50
@SebastianKrupinski
Copy link
Contributor

@hamza221 any objections?

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@hamza221
Copy link
Contributor

hamza221 commented Jan 18, 2026

We might need to fully remove debounce completely for button click, I don't think it makes sense debouncing at all here.
The method is used by other components (so debouce should stay for them and removed only for button click) I can update the PR if needed

@SebastianKrupinski
Copy link
Contributor

I think the de-bounce is on the input not the button click. It slows the update of the contact object from my reading of the code. Its part of the property mixins, it was added 8 years ago so hard to know what the purpose was

Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a second look at the code, It weird that most components overwrite it, I think we actually need to clean the code here.
Approving as a temporary fix, but not sure if we should merge. I can take a deep five next week

@SebastianKrupinski
Copy link
Contributor

Okay, Look in to it... then merge it if it makes sense...

@hamza221 hamza221 marked this pull request as draft January 18, 2026 17:24
@hamza221
Copy link
Contributor

Set to draft to avoid accidental merge until next week, @max65482 I hope you're okay with that 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hitting the save button too quickly doesn't save the changes

3 participants