-
Notifications
You must be signed in to change notification settings - Fork 198
Fix: improve reactivity by reducing debounce time for value changes #5010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
00250a8 to
caf81ef
Compare
|
@hamza221 any objections? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
We might need to fully remove debounce completely for button click, I don't think it makes sense debouncing at all here. |
|
I think the de-bounce is on the input not the button click. It slows the update of the contact object from my reading of the code. Its part of the property mixins, it was added 8 years ago so hard to know what the purpose was |
hamza221
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a second look at the code, It weird that most components overwrite it, I think we actually need to clean the code here.
Approving as a temporary fix, but not sure if we should merge. I can take a deep five next week
|
Okay, Look in to it... then merge it if it makes sense... |
|
Set to draft to avoid accidental merge until next week, @max65482 I hope you're okay with that 😊 |
Fixes #4994 by decreasing debounce time from 500 ms to 250 ms.