fix(talkService): make attendees be synced with talk room members#7733
Merged
fix(talkService): make attendees be synced with talk room members#7733
Conversation
Signed-off-by: Grigory V <scratchx@gmx.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
SebastianKrupinski
approved these changes
Nov 30, 2025
Contributor
|
If the issue was the / getting encoded, did you check if the other paths are okay? Like "room/${token}/participants"?? |
Contributor
Author
Where is that being used? @SebastianKrupinski |
Contributor
During event create or update, in the talkService, first we create a room then we update the participants on save, but first we pull the existing participants |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following bug:
The issue was the
/becoming encoded as a%2F