Skip to content

fix(share): secure file drop#16657

Open
alperozturk96 wants to merge 5 commits intomasterfrom
fix/secure-file-drop
Open

fix(share): secure file drop#16657
alperozturk96 wants to merge 5 commits intomasterfrom
fix/secure-file-drop

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 commented Mar 11, 2026 •
edited
Loading

Web Android
before after

Ignore the folder name I used different folder for tests

Web Android
before after

Out of scope

Matching %100 same UI/UX.
Purpose of this PR is just fixing logic and align wording as much as possible.

@alperozturk96 alperozturk96 force-pushed the fix/secure-file-drop branch 2 times, most recently from 71f20bc to aacee8a Compare March 25, 2026 07:13
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16657.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 added this to the Nextcloud App 33.1.0 milestone Mar 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23536231327/artifacts/6099131018
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23640216825/artifacts/6141269972
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
fix(share): secure file drop
7dc7320 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
align wording style with web
ef46fba 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
use latest e2ee counter
ff56b3e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix search view enability
6f0e77f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix search view enability
40a2906 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the fix/secure-file-drop branch from 77770cf to 40a2906 Compare April 1, 2026 06:23
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice3838
Correctness7070
Dodgy code231231
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total441441

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

APK file: https://github.com/nextcloud/android/actions/runs/23835065328/artifacts/6214740846
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 requested a review from mahibi April 1, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@mahibi mahibi Awaiting requested review from mahibi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 33.1.0

Development

Successfully merging this pull request may close these issues.

1 participant

@alperozturk96