Skip to content

fix(file-listing): action bar title after preview #16436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alperozturk96 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(file-listing): action bar title after preview #16436

alperozturk96 wants to merge 1 commit into from
+1 −0

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 3, 2026 •
edited
Loading

  • Tests written, or not not needed

Issue

Last opened PDF file name appears in action bar.

How to reproduce?

  1. Upload large pdf file along with multiple images
  2. Open large pdf file press back
  3. Open image file press back
  4. Action bar title still showing the pdf file's name

@alperozturk96
fix(file-listing): action bar title when user comes back from preview…
e15bf31 
… image

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 changed the title fix(file-listing): action bar title when user comes back from preview… fix(file-listing): action bar title when user comes back from preview image Feb 3, 2026
@alperozturk96 alperozturk96 requested a review from ZetaTom February 3, 2026 15:40
alperozturk96
alperozturk96 commented Feb 3, 2026
View reviewed changes
app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
} else if (!ocFileListFragment.isSearchFragment && startFile == null) {
updateListOfFilesFragment()
ocFileListFragment.registerFabListener()
updateActionBarTitleAndHomeButton(currentDir)
Copy link
Collaborator Author

@alperozturk96 alperozturk96 Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this line will be executed only for file listing using current directory for action bar title should be okay.

@ZetaTom Could you please double-check this?

@alperozturk96
Copy link
Collaborator Author

alperozturk96 commented Feb 3, 2026

/backport to stable-3.35

@alperozturk96 alperozturk96 changed the title fix(file-listing): action bar title when user comes back from preview image fix(file-listing): action bar title after preview Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code258258
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4343
Security1818
Total481481

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16436.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

3. to review backport-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96