fix(manage-space-activity): app in foreground

[alperozturk96]

• Tests written, or not not needed

Issue

App is crashing when user trying to open the app after deleting data.

How to reproduce?

1. Open the app and log in.
2. Send the app to the background.
3. Go to the app’s settings.
4. Begin the process to delete the app’s data and confirm.
5. Attempt to reopen the app afterward.

[alperozturk96]

Ideally, FileDisplayActivity should not be launched after all accounts are removed on APP_RESUME. However, the app uses quite a bit of complex logic during startup.

Currently, FirstRunActivity, OnboardingServiceImpl, LauncherActivity, and AuthenticatorActivity all play a role in triggering the login flow and eventually FileDisplayActivity. To be honest, I’m not entirely sure why the app has four different launcher-related activities.

If you have any suggestions or ideas on a better approach to handle this, I’d really appreciate your feedback.

@ZetaTom @tobiasKaminsky

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	43	43
Correctness	74	74
Dodgy code	258	258
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	3	3
Multithreaded correctness	34	34
Performance	43	43
Security	18	18
Total	481	481

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16435.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.