Closed
Conversation
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
requested review from
AndyScherzinger,
stefan-niedermann and
tobiasKaminsky
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
added
2. developing
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
added
3. to review
Contributor
Author
|
|
alperozturk96
removed request for
AndyScherzinger,
stefan-niedermann and
tobiasKaminsky
1 task
Contributor
Author
|
Android Files application is responsible for handling 304 response, thus this PR is not valid anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Some responses can be completely empty: either entirely \u0000 (null characters) or just whitespace. Passing to the
Gson.fromJson()causing JSON parsing exceptions.Needed for: nextcloud/notes-android#2883
Changes
Before attempting deserialization, the
isReaderContainsEmptyResponsepeeks at the first 64 characters. If all characters are either:\u0000(null characters) or whitespace(' ', '\t', '\n', '\r')then the stream is considered “empty” or “ignorable.”