Add Logback13 Plugin #109
Merged
Add Logback13 Plugin #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtduffy
previously approved these changes
Jun 24, 2025
Contributor
jtduffy
left a comment
jtduffy
left a comment
There was a problem hiding this comment.
Just 2 minor nits. Excellent README and comments. 👍
logback13/src/main/java/com/newrelic/logging/logback13/NewRelicAsyncAppender.java
Outdated
Show resolved
Hide resolved
logback13/src/main/java/com/newrelic/logging/logback13/NewRelicJsonLayout.java
Outdated
Show resolved
Hide resolved
jtduffy
requested changes
Jun 27, 2025
logback13/src/main/java/com/newrelic/logging/logback13/NewRelicJsonLayout.java
Outdated
Show resolved
Hide resolved
jtduffy
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #107