Add unit tests for roleArn validation when stsEnabled is true#162
Merged
Add unit tests for roleArn validation when stsEnabled is true#162
Conversation
Co-authored-by: stevehu <2042337+stevehu@users.noreply.github.com> Agent-Logs-Url: https://github.com/networknt/light-aws-lambda/sessions/9112dc37-502e-4d9a-9701-cb1fa8121d5b
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from PR #161 on roleArn validation implementation
Add unit tests for roleArn validation when stsEnabled is true
Mar 20, 2026
stevehu
approved these changes
Mar 20, 2026
stevehu
added a commit
that referenced
this pull request
Mar 20, 2026
* fixes #160 Add validation for roleArn to avoid NPE * Add unit tests for roleArn validation when stsEnabled is true (#162) * Initial plan * Add unit tests for roleArn validation when stsEnabled is true Co-authored-by: stevehu <2042337+stevehu@users.noreply.github.com> Agent-Logs-Url: https://github.com/networknt/light-aws-lambda/sessions/9112dc37-502e-4d9a-9701-cb1fa8121d5b --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stevehu <2042337+stevehu@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: stevehu <2042337+stevehu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
validate()method inLambdaInvokerConfigthrowsConfigExceptionwhenstsEnabled=truebutroleArnis blank — this fail-fast behavior had no test coverage.Changes
New test YAML configs in
src/test/resources/config/:lambda-invoker-sts-no-role.yml—stsEnabled: true,roleArnblanklambda-invoker-sts-with-role.yml—stsEnabled: true,roleArnset to a valid ARNTwo new tests in
LambdaInvokerConfigTest:testStsEnabledWithoutRoleArnThrowsConfigException— assertsConfigExceptionis thrown on loadtestStsEnabledWithRoleArnSucceeds— asserts clean load and correctroleArnvalue💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.