Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ private LambdaInvokerConfig(String configName) {
mappedConfig = Config.getInstance().getJsonMapConfig(configName);
setConfigData();
setConfigMap();
validate();
}

public static LambdaInvokerConfig load() {
Expand Down Expand Up @@ -453,4 +454,10 @@ private void setConfigMap() {
functions = Collections.emptyMap();
}
}

private void validate() {
if (stsEnabled && (roleArn == null || roleArn.trim().isEmpty())) {
throw new ConfigException(ROLE_ARN + " must be configured when " + STS_ENABLED + " is true.");
}
}
}
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
package com.networknt.aws.lambda;

import com.networknt.config.Config;
import com.networknt.config.ConfigException;
import com.networknt.config.JsonMapper;
import org.junit.jupiter.api.Test;

import java.util.Map;

import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertEquals;

public class LambdaInvokerConfigTest {
private static LambdaInvokerConfig config = (LambdaInvokerConfig) Config.getInstance().getJsonObjectConfig(LambdaInvokerConfig.CONFIG_NAME, LambdaInvokerConfig.class);

Expand All @@ -14,4 +19,17 @@ public void testFunctionMapping() {
Map<String, String> functions = config.getFunctions();
System.out.println(JsonMapper.toJson(functions));
}

@Test
public void testStsEnabledWithoutRoleArnThrowsConfigException() {
assertThrows(ConfigException.class, () -> LambdaInvokerConfig.load("lambda-invoker-sts-no-role"),
"ConfigException was not thrown despite stsEnabled=true with blank roleArn");
}

@Test
public void testStsEnabledWithRoleArnSucceeds() {
LambdaInvokerConfig stsConfig = LambdaInvokerConfig.load("lambda-invoker-sts-with-role");
assertNotNull(stsConfig);
assertEquals("arn:aws:iam::123456789012:role/TestRole", stsConfig.getRoleArn());
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
stsEnabled: true
roleArn:
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
stsEnabled: true
roleArn: arn:aws:iam::123456789012:role/TestRole