chore(ci): pin Node.js 24#8279
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR updates CI configuration to enable Node installation version overrides. .github/test-matrix.yml adds a node_install_overrides map that pins Node 24 to 24.15.0. .github/workflows/integration-tests.yml now resolves node-install-version from that map when generating shard matrix entries and uses matrix.node-install-version in the actions/setup-node step with check-latest set to false. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/integration-tests.yml:
- Line 90: The workflow step currently references a floating ref "uses:
actions/setup-node@v6"; update that step to pin to an immutable commit SHA (or
digest) for actions/setup-node instead of the major tag. Locate the step that
contains the string "uses: actions/setup-node@v6" and replace it with the same
action pinned to a specific commit SHA (e.g., uses:
actions/setup-node@<FULL_COMMIT_SHA>) so the workflow uses an immutable
reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b638b9ea-b503-454d-b388-a0b83b03e60e
📒 Files selected for processing (2)
.github/test-matrix.yml.github/workflows/integration-tests.yml
|
|
||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| - name: Use Node.js ${{ matrix.node-install-version }} | ||
| uses: actions/setup-node@v6 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE=".github/workflows/integration-tests.yml"
echo "== File: $FILE (lines 70-110) =="
nl -ba "$FILE" | sed -n '70,110p'
echo
echo "== All uses: actions/setup-node occurrences =="
rg -n "uses:\s*actions/setup-node@" "$FILE" || trueRepository: netlify/cli
Length of output: 183
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE=".github/workflows/integration-tests.yml"
echo "== Segment (grep line numbers for context) =="
grep -n "setup-node@" "$FILE" || true
echo
echo "== Segment lines 70-110 (raw) =="
sed -n '70,110p' "$FILE" || true
echo
echo "== Full lines matching actions/setup-node@ =="
rg -n "uses:\s*actions/setup-node@" "$FILE" || trueRepository: netlify/cli
Length of output: 1584
Pin actions/setup-node to a full commit SHA.
.github/workflows/integration-tests.yml uses uses: actions/setup-node@v6 (floating ref); pinning to an immutable commit SHA/digest is needed to prevent unexpected upstream changes.
🧰 Tools
🪛 zizmor (1.25.2)
[error] 90-90: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/integration-tests.yml at line 90, The workflow step
currently references a floating ref "uses: actions/setup-node@v6"; update that
step to pin to an immutable commit SHA (or digest) for actions/setup-node
instead of the major tag. Locate the step that contains the string "uses:
actions/setup-node@v6" and replace it with the same action pinned to a specific
commit SHA (e.g., uses: actions/setup-node@<FULL_COMMIT_SHA>) so the workflow
uses an immutable reference.
There was a problem hiding this comment.
Not relevant to this PR. This is a separate pre-existing concern
There was a problem hiding this comment.
@pieh, understood — this is a pre-existing concern unrelated to the changes in this PR. Would you like me to open a follow-up GitHub issue to track pinning actions/setup-node to an immutable commit SHA? I can also resolve this review comment if you'd like.
2 participants
No description provided.