Skip to content

Conversation

@yanguoyu
Copy link
Contributor

@yanguoyu yanguoyu commented Aug 7, 2024

If we have set the env that includes scripts info, use the env value to replace the lumos config.

@yanguoyu yanguoyu marked this pull request as ready for review August 13, 2024 00:16
@yanguoyu
Copy link
Contributor Author

@Keith-CY @homura @devchenyan please have a review

@homura
Copy link
Contributor

homura commented Aug 13, 2024

Is the PR created to allow Neuron to work with a network that isn't mainnet or testnet?

@yanguoyu
Copy link
Contributor Author

Is the PR created to allow Neuron to work with a network that isn't mainnet or testnet?

That's it, For example, #3026 this PR uses devnet.

@homura
Copy link
Contributor

homura commented Aug 13, 2024

That's it, For example, #3026 this PR uses devnet.

It would be helpful to provide a comment or documentation explaining how to utilize a devnet by overriding the env variables

If we have set the env that includes scripts info, use the env value to replace the lumos config.
@yanguoyu yanguoyu force-pushed the feat-support-load-env branch from 3251244 to f1c6c84 Compare August 14, 2024 00:25
@Keith-CY Keith-CY added this pull request to the merge queue Aug 14, 2024
Merged via the queue into nervosnetwork:develop with commit e9eab5e Aug 14, 2024
@yanguoyu yanguoyu deleted the feat-support-load-env branch August 14, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants