feat: monitor fiber store changes for cch #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitian
force-pushed
the
feature/cch-monitor-store-changes
branch
from
ddc60c0 to
c589196
Compare
doitian
force-pushed
the
feature/cch-monitor-store-changes
branch
from
c589196 to
abf7623
Compare
doitian
force-pushed
the
feature/cch-monitor-store-changes
branch
6 times, most recently
from
1e9163b to
77713af
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #950 +/- ##
========================================
Coverage 0.00% 0.00%
========================================
Files 61 64 +3
Lines 38210 38322 +112
========================================
- Misses 38210 38322 +112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chenyukang
reviewed
Nov 17, 2025
chenyukang
reviewed
Nov 17, 2025
Comment on lines
+77
to
+89
| pub fn is_incoming_invoice_fiber(&self) -> bool { | ||
| matches!(self.incoming_invoice, CchInvoice::Fiber(_)) | ||
| } | ||
| pub fn is_incoming_invoice_lnd(&self) -> bool { | ||
| matches!(self.incoming_invoice, CchInvoice::Lightning(_)) | ||
| } | ||
| pub fn is_outgoing_payment_fiber(&self) -> bool { | ||
| self.is_incoming_invoice_lnd() | ||
| } | ||
| pub fn is_outgoing_payment_lnd(&self) -> bool { | ||
| self.is_incoming_invoice_fiber() | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
the later 2 functions are just alias of the first 2 functions,
proper function naming to keep only 2 function seems more maintainable.
Member
Author
There was a problem hiding this comment.
The extra 2 functions make code easy to reason. In the place I want to ensure the order is sending outgoing payment to fiber, I can use is_outgoing_payment_fiber. It's more straightforward than is_incoming_invoice_lnd since I have to reason that when incoming invoice is from lnd, the outgoing payment is to fiber.
doitian
force-pushed
the
feature/cch-monitor-store-changes
branch
2 times, most recently
from
92c0931 to
58f7f76
Compare
Member
Author
|
Convert to Draft. Wait on #934 |
doitian
force-pushed
the
feature/cch-monitor-store-changes
branch
from
58f7f76 to
e75a7da
Compare
Member
Author
doitian
force-pushed
the
feature/cch-monitor-store-changes
branch
2 times, most recently
from
a7b2dad to
327aed0
Compare
1 task
- Define payment and invoice events to be sent to CCH for both fiber and lnd. - These events can be emitted from fiber store changes in a later PR. - Extract lnd trackers into its own module. - Limit concurrent lnd invoice trackers to 5, scheduling them at 5-minute intervals using a round-robin strategy.
Add gauges to monitor the LND tracker's internal state for better observability. - Track invoice queue length to monitor backlog size - Monitor count of active invoice trackers for capacity awareness - Conditionally compile metrics behind "metrics" feature flag
- When an invoice state changes in Fiber (settled, failed, expired), the CCH order tracking system automatically detects and synchronizes the state without manual polling or intervention. - When an outgoing payment state changes in Fiber (succeeded, failed, pending), the CCH order tracking system automatically detects and synchronizes the state without requiring manual status checks. - CCH monitors invoice for the incoming payment. When CCH has received the incoming payment, it will send the outgoing payment to get the preimage. - CCH monitors outgoing payment to get the preimage and use the obtained preimage the settle the incoming payment.
doitian
force-pushed
the
feature/cch-monitor-store-changes
branch
from
327aed0 to
f196421
Compare
chenyukang
approved these changes
Dec 15, 2025
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a stacked PR:
This PR will deprecate #615, which has been refactored and split into
Actions: