Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the default quota registration migration to include an OpenStack GPU quota entry, so newly migrated OpenStack resources get a GPU-related quota attribute alongside existing compute/network/storage quotas.
Changes:
- Add a new OpenStack default quota entry for
attributes.QUOTA_GPU. - Register the new quota with quota label
internal.gpu_quotaduring theregister_default_quotasmigration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/coldfront_plugin_cloud/management/commands/register_default_quotas.py
Outdated
Show resolved
Hide resolved
| }, | ||
| { | ||
| "display_name": attributes.QUOTA_GPU, | ||
| "quota_label": "internal.gpu_quota", |
There was a problem hiding this comment.
This new quota entry omits fields (e.g. multiplier, static_quota, unit_suffix) that every other default quota passes through to add_quota_to_resource. For consistency and to avoid depending on implicit defaults/CLI optionality, set them explicitly (likely multiplier: 0, static_quota: 0, unit_suffix: ""). Also, the unit test for register_default_quotas asserts the exact set of OpenStack default quota keys and will need to include attributes.QUOTA_GPU once this is added.
| "quota_label": "internal.gpu_quota", | |
| "quota_label": "internal.gpu_quota", | |
| "multiplier": 0, | |
| "static_quota": 0, | |
| "unit_suffix": "", |
…t_quotas.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.