Use new estimate endpoint (take 2) #1025
Open
+131
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FlorentinD
commented
Dec 4, 2025
FlorentinD
commented
- Reapply "Fix estimation endpoint take 3"
- Reapply "Use new estimate endpoint on Aura API"
- Allow list of str for algo categories as well
✅ Deploy Preview for neo4j-graph-data-science-client ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
FlorentinD
commented
Dec 4, 2025
FlorentinD
force-pushed
the
gdsa-483-use-new-estimate-endpoint-in-python-client
branch
from
28589ba to
53a204e
Compare
Mats-SX
approved these changes
Dec 11, 2025
Contributor
Mats-SX
left a comment
Mats-SX
left a comment
There was a problem hiding this comment.
I had some concerns that were incorrect. I think this is good.
| node_count: int, | ||
| relationship_count: int, | ||
| algorithm_categories: list[AlgorithmCategory] | None = None, | ||
| algorithm_categories: list[AlgorithmCategory] | list[str] | None = None, |
Contributor
There was a problem hiding this comment.
Do you have to include | None for the typing? 🤔
Contributor
Author
There was a problem hiding this comment.
yes its for the typing
Contributor
Author
There was a problem hiding this comment.
the new part here is allowing also for the raw strings
Comment on lines
+58
to
+61
| Parameters | ||
| ---------- | ||
| api_credentials | ||
| The Aura API credentials used for establishing a connection. |
Comment on lines
+76
to
+79
| algorithm_categories: list[AlgorithmCategory] | list[str] | None = None, | ||
| node_label_count: int = 0, | ||
| node_property_count: int = 0, | ||
| relationship_property_count: int = 0, |
Comment on lines
+1223
to
+1228
| assert EstimationDetails._parse_size("8GB") == 8589934592 | ||
| assert EstimationDetails._parse_size("8G") == 8589934592 | ||
| assert EstimationDetails._parse_size("512MB") == 536870912 | ||
| assert EstimationDetails._parse_size("256KB") == 262144 | ||
| assert EstimationDetails._parse_size("1024B") == 1024 | ||
| assert EstimationDetails._parse_size("12345") == 12345 |
Contributor
There was a problem hiding this comment.
great tests, but I am missing one case with an i suffix, and also some lower-case inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.