feature: If hidden="until-found", it's not display: none.#879
Open
yamanoku wants to merge 2 commits intonecolas:masterfrom
Open
feature: If hidden="until-found", it's not display: none.#879yamanoku wants to merge 2 commits intonecolas:masterfrom
hidden="until-found", it's not display: none.#879yamanoku wants to merge 2 commits intonecolas:masterfrom
Conversation
There was a problem hiding this comment.
I came here looking exactly for this change, great to see this is already being worked on!
Just wanted to also suggest updating the comment to make it clear this isn’t just for legacy browser support – hidden also isn’t supported by SVG elements inline in HTML, which is very surprising. I’m not sure if this was considered when creating this specific bit of the reset, but now that this code is widely used it’d be problematic to remove this for projects that don’t care about IE10 support.
See for example Tailwind discussion on a similar change.
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
abdellah259
reviewed
Nov 19, 2022
| display: none; | ||
| } | ||
|
|
||
| [hidden="until-found"] { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hiddenattribute, which used to have only a boolean value, now also has a newuntil-foundvalue.ref: whatwg/html@f5def65
Elements with
hidden="until-found"will havecontent-visibility: hiddenapplied instead ofdisplay: none.If specified with
display: none, it may not be found in in-page searches.ref: HTML の hidden 属性が列挙型に変更され hidden="until-found" が追加
To avoid this problem, the style specification for
hiddencase has been modified.sample: https://codepen.io/yamanoku/pen/YzYpoqG